Re: [PATCH 01/11] MFD: DA9052 MFD core module v8

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Fri, Dec 02, 2011 at 01:57:49PM +0000, Ashish Jangam wrote:
> > On Fri, Nov 18, 2011 at 02:49:54PM +0530, Ashish Jangam wrote:

> > > +	da9052_i2c->bustype = BUS_I2C;

> > bustype should be redundant now, it certianly doesn't seem to be
> > referred to in this patch.

> This is required in the TSI driver.

You can just query the bus_type of the struct device if you really need
this.

> > > + * Interrupt controller support for Dilaog DA9052 PMICs.

> > This looks very much like it could be replaced with regmap-irq.  The
> > code would be slightly less efficient due to the support for sparse
> > interrupt registers but it'd be less code.

> regmap-irq has a opaque struct regmap_irq_chip_data which has a member
> irq_base and this is required for non-primary irqs registration
> and also the clean-up function regmap_del_irq_chip() requires it.
> So as of now I will keep the current irq implementation as it is. 

I'm not sure how this is relevant to my above comment?  The struct is of
course opaque since it is only used by the implementation.