From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcos Paulo de Souza <marcos.mage@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/2] staging: vt6656: aes_ccmp, baseband, bssdb, card: Change BOOL to int
Date: Mon, 5 Dec 2011 09:55:18 +0300 [thread overview]
Message-ID: <20111205065517.GC3236@mwanda> (raw)
In-Reply-To: <1323047566-12650-1-git-send-email-marcos.mage@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On Sun, Dec 04, 2011 at 11:12:46PM -0200, Marcos Paulo de Souza wrote:
> This patch change all references of BOOL to int. As asked by the TODO
> file of the driver, we need to remove the ttype.h, and this file do a
> typedef of int to BOOL. We don't need this.
>
Why not use bool? Especially inside structs bool takes up less
space than an int. Also static analysis tools care about the type.
Changing the type from int to bool is a code change so it needs
careful auditing. It's not a problem if you don't have this
hardware, but you've been sending quite a few patches for it, so I'm
curious if you do? If you did, and you made a code change then it
helps us to know if you have tested it.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-05 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 1:12 [PATCH 1/2] staging: vt6656: aes_ccmp, baseband, bssdb, card: Change BOOL to int Marcos Paulo de Souza
2011-12-05 6:55 ` Dan Carpenter [this message]
2011-12-06 0:41 ` Marcos Paulo de Souza
2011-12-06 6:10 ` Dan Carpenter
[not found] ` <alpine.LNX.2.00.1112071922560.2146@darkstar.example.net>
2011-12-08 6:19 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205065517.GC3236@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcos.mage@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox