From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: ashishj3 <ashish.jangam@kpitcummins.com>
Cc: sameo@openedhand.com, linux-kernel@vger.kernel.org,
Dajun <dajun.chen@diasemi.com>,
linaro-dev@lists.linaro.org, arnd@arndb.de, eric.miao@linaro.org,
sameo@linux.intel.com
Subject: Re: [PATCH 01/11] MFD: DA9052/53 MFD core module v8
Date: Mon, 5 Dec 2011 15:27:15 +0000 [thread overview]
Message-ID: <20111205152715.GT11150@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1323067584.1652.10.camel@L-0761.kpit.com>
On Mon, Dec 05, 2011 at 12:16:24PM +0530, ashishj3 wrote:
> --- a/drivers/base/regmap/regmap-irq.c
> +++ b/drivers/base/regmap/regmap-irq.c
> @@ -164,7 +164,6 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
> * irq: The IRQ the device uses to signal interrupts
> * irq_flags: The IRQF_ flags to use for the primary interrupt.
> * chip: Configuration for the interrupt controller.
> - * data: Runtime data structure for the controller, allocated on success
Uh, that's not good...
> - irq_base = irq_alloc_descs(irq_base, 0, chip->num_irqs, 0);
> - if (irq_base < 0) {
> + *irq_base = irq_alloc_descs(*irq_base, 0, chip->num_irqs, 0);
> + if (*irq_base < 0) {
This isn't adding an accessory, this is passing irq_base by reference.
Seems like a lot of pointers, really. I'll send a patch.
prev parent reply other threads:[~2011-12-05 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 12:55 [PATCH 01/11] MFD: DA9052/53 MFD core module v8 ashishj3
2011-11-01 13:02 ` Mark Brown
2011-12-05 6:46 ` ashishj3
2011-12-05 15:27 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205152715.GT11150@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dajun.chen@diasemi.com \
--cc=eric.miao@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sameo@openedhand.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox