From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932797Ab1LERoI (ORCPT ); Mon, 5 Dec 2011 12:44:08 -0500 Received: from mail-iy0-f174.google.com ([209.85.210.174]:42786 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756511Ab1LERoG (ORCPT ); Mon, 5 Dec 2011 12:44:06 -0500 Date: Mon, 5 Dec 2011 09:43:49 -0800 From: Tejun Heo To: "Srivatsa S. Bhat" Cc: rjw@sisk.pl, pavel@ucw.cz, len.brown@intel.com, ebiederm@xmission.com, rdunlap@xenotime.net, linux-doc@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 3/3] PM / Docs: Recommend the use of [un]lock_system_sleep() over mutex_[un]lock(&pm_mutex) Message-ID: <20111205174349.GG627@google.com> References: <20111204200208.25620.515.stgit@srivatsabhat.in.ibm.com> <20111204200332.25620.53610.stgit@srivatsabhat.in.ibm.com> <20111205171508.GC627@google.com> <4EDD019E.9010009@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EDD019E.9010009@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Dec 05, 2011 at 11:08:38PM +0530, Srivatsa S. Bhat wrote: > Sorry, I didn't get what you meant here. Are you talking about what > needs to be added/changed in the documentation or, are you referring > to the code itself and are saying that we must make these APIs > internal to the PM alone? Ooh, sorry about not being clear. I meant pm_mutex itself. There's no reason to expose that outside of pm, right? And in the documentation, we can just require use of the APIs instead of pm_mutex itself. Thank you. -- tejun