From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932317Ab1LETSd (ORCPT ); Mon, 5 Dec 2011 14:18:33 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:45678 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161Ab1LETSc (ORCPT ); Mon, 5 Dec 2011 14:18:32 -0500 Date: Mon, 5 Dec 2011 22:22:02 +0300 From: Sergei Trofimovich To: Tejun Heo Cc: Jens Axboe , Ralf Hildebrandt , linux-kernel@vger.kernel.org Subject: Re: [regression] WARNING: at drivers/block/floppy.c:2929 do_fd_request+0xb7/0xb9() in 3.2.0-rc2 and 3 Message-ID: <20111205222202.3ede37f3@sf.home> In-Reply-To: <20111205183236.GI627@google.com> References: <20111125103420.GO4581@charite.de> <20111205202114.6457443b@sf.home> <20111205183236.GI627@google.com> X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.5; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/5=QcO40_NyNZDP4erBCK5V7"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/5=QcO40_NyNZDP4erBCK5V7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 5 Dec 2011 10:32:36 -0800 Tejun Heo wrote: > On Mon, Dec 05, 2011 at 08:21:14PM +0300, Sergei Trofimovich wrote: > > Same here on 3.2.0-rc4-00077-g5983fe2 > >=20 > > 'swapper' cmd looks suspicious. > > [ CCing someone who is familar with block layer, sorry in advance ] > >=20 > > [ 3.792015] floppy0: no floppy controllers found > > [ 3.792274] ------------[ cut here ]------------ > > [ 3.792434] WARNING: at drivers/block/floppy.c:2929 do_fd_request+0x= bf/0xd0() > > [ 3.792587] Hardware name: To Be Filled By O.E.M. > > [ 3.792738] VFS: do_fd_request called on non-open device > > [ 3.792889] Modules linked in: > > [ 3.793008] Pid: 1, comm: swapper Not tainted 3.2.0-rc4-00077-g5983f= e2 #2 > > [ 3.793008] Call Trace: > > [ 3.793008] [] warn_slowpath_common+0x7a/0xb0 > > [ 3.793008] [] warn_slowpath_fmt+0x41/0x50 > > [ 3.793008] [] do_fd_request+0xbf/0xd0 > > [ 3.793008] [] blk_drain_queue+0x65/0x80 > > [ 3.793008] [] blk_cleanup_queue+0xe3/0x1a0 > > [ 3.793008] [] floppy_init+0xdeb/0xe28 > > [ 3.793008] [] ? daring+0x6b/0x6b > > [ 3.793008] [] do_one_initcall+0x3f/0x170 > > [ 3.793008] [] kernel_init+0x9d/0x11e > > [ 3.793008] [] ? schedule_tail+0x22/0xa0 > > [ 3.793008] [] kernel_thread_helper+0x4/0x10 > > [ 3.793008] [] ? start_kernel+0x2be/0x2be > > [ 3.793008] [] ? gs_change+0xb/0xb > > [ 3.793008] ---[ end trace c5807061655fec8c ]--- >=20 > Does the following patch make the warning go away? It does. Thank you! Tried to boot only once with patch though (is bug deterministic?) > Thanks. >=20 > block/blk-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/block/blk-core.c b/block/blk-core.c > index ea70e6c..653cc22 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -366,7 +366,8 @@ void blk_drain_queue(struct request_queue *q, bool dr= ain_all) > if (drain_all) > blk_throtl_drain(q); > =20 > - __blk_run_queue(q); > + if (!list_empty(&q->queue_head)) > + __blk_run_queue(q); > =20 > if (drain_all) > nr_rqs =3D q->rq.count[0] + q->rq.count[1]; --=20 Sergei --Sig_/5=QcO40_NyNZDP4erBCK5V7 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iEYEARECAAYFAk7dGeMACgkQcaHudmEf86pqoQCeLuvynSjM25m78GtNTXFqXz4d pZsAn1+9ZBL0mnJV0HFPQVKd7rt0fM8j =1Jpw -----END PGP SIGNATURE----- --Sig_/5=QcO40_NyNZDP4erBCK5V7--