From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org, Rabin Vincent <rabin@rab.in>
Subject: [PATCH 3/6] ftrace: Remove force undef config value left for testing
Date: Mon, 05 Dec 2011 20:41:13 -0500 [thread overview]
Message-ID: <20111206014221.007066295@goodmis.org> (raw)
In-Reply-To: 20111206014110.079874115@goodmis.org
[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
A forced undef of a config value was used for testing and was
accidently left in during the final commit. This causes x86 to
run slower than needed while running function tracing as well
as causes the function graph selftest to fail when DYNMAIC_FTRACE
is not set. This is because the code in MCOUNT expects the ftrace
code to be processed with the config value set that happened to
be forced not set.
The forced config option was left in by:
commit 6331c28c962561aee59e5a493b7556a4bb585957
ftrace: Fix dynamic selftest failure on some archs
Link: http://lkml.kernel.org/r/20111102150255.GA6973@debian
Cc: stable@vger.kernel.org
Reported-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/ftrace.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 900b409..1276b3c 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -152,7 +152,6 @@ void clear_ftrace_function(void)
ftrace_pid_function = ftrace_stub;
}
-#undef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST
#ifndef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST
/*
* For those archs that do not test ftrace_trace_stop in their
--
1.7.7.3
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-12-06 1:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 1:41 [PATCH 0/6] [GIT PULL][v3.2] tracing: fixes Steven Rostedt
2011-12-06 1:41 ` [PATCH 1/6] tracing: fix event_subsystem ref counting Steven Rostedt
2011-12-06 1:41 ` [PATCH 2/6] tracing: Restore system filter behavior Steven Rostedt
2011-12-06 1:41 ` Steven Rostedt [this message]
2011-12-06 1:41 ` [PATCH 4/6] jump_label: jump_label_inc may return before the code is patched Steven Rostedt
2011-12-06 1:41 ` [PATCH 5/6] perf: Fix parsing of __print_flags() in TP_printk() Steven Rostedt
2011-12-06 1:41 ` [PATCH 6/6] ftrace: Fix hash record accounting bug Steven Rostedt
2011-12-06 5:43 ` [PATCH 0/6] [GIT PULL][v3.2] tracing: fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206014221.007066295@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rabin@rab.in \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox