Re: [PATCH 1/2] staging: vt6656: aes_ccmp, baseband, bssdb, card: Change BOOL to int

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

On Mon, Dec 05, 2011 at 10:41:54PM -0200, Marcos Paulo de Souza wrote:
> On Mon, 5 Dec 2011, Dan Carpenter wrote:
> >On Sun, Dec 04, 2011 at 11:12:46PM -0200, Marcos Paulo de Souza wrote:
> >>This patch change all references of BOOL to int. As asked by the TODO
> >>file of the driver, we need to remove the ttype.h, and this file do a
> >>typedef of int to BOOL. We don't need this.
> 
> Dan, I'm trying to remove this chunk of code:
> 
> drivers/staging/vt6656/ttype.h:
> 
> typedef int BOOL;
> 
> Are we talinkg about the same BOOL type?
> 

Yes.

> >
> >Why not use bool?  Especially inside structs bool takes up less
> >space than an int.  Also static analysis tools care about the type.
> 
> This typedef is about a int type.

Yes.  I know that.  But these things are used like bool not like int
so bool is the correct thing.

Bool is a different type from int, so you'll have to verify that
changing it doesn't break anything.  It's a more difficult change
but it's the right thing to do.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]