From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753118Ab1LFGSP (ORCPT ); Tue, 6 Dec 2011 01:18:15 -0500 Received: from 1.mo1.mail-out.ovh.net ([178.32.127.22]:43807 "EHLO mo1.mail-out.ovh.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752812Ab1LFGSN (ORCPT ); Tue, 6 Dec 2011 01:18:13 -0500 X-Greylist: delayed 52392 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Dec 2011 01:18:13 EST Date: Tue, 6 Dec 2011 07:13:21 +0100 From: Jean-Christophe PLAGNIOL-VILLARD To: Alan Cox Cc: Nicolas Pitre , Stephen Rothwell , Russell King - ARM Linux , Pawel Moll , devicetree-discuss@lists.ozlabs.org, LKML , Jeff Garzik , linux-ide@vger.kernel.org, Randy Dunlap , linux-next@vger.kernel.org, Anton Vorontsov , Andrew Morton , Linus Torvalds , Ingo Molnar , linux-arm-kernel@lists.infradead.org X-Ovh-Mailout: 178.32.228.1 (mo1.mail-out.ovh.net) Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver Message-ID: <20111206061321.GH9192@game.jcrosoft.org> References: <20111110162859.GA7088@oksana.dev.rtsoft.ru> <20111202192618.GC3037@localhost.localdomain> <1322867573.11728.22.camel@pasglop> <20111205161157.GA27550@localhost.localdomain> <20111205180253.GB29812@localhost.localdomain> <20111205184522.316598de@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111205184522.316598de@lxorguk.ukuu.org.uk> X-PGP-Key: http://uboot.jcrosoft.org/plagnioj.asc X-PGP-key-fingerprint: 6309 2BBA 16C8 3A07 1772 CC24 DEFC FFA3 279C CE7C User-Agent: Mutt/1.5.20 (2009-06-14) X-Ovh-Tracer-Id: 12923923555944409957 X-Ovh-Remote: 213.251.161.87 (ns32433.ovh.net) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeefjedrudefucetggdotefuucfrrhhofhhilhgvmecuqfggjfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgggtuggjfgesthdttfdttdervdenucfhrhhomheplfgvrghnqdevhhhrihhsthhophhhvgcurffntefipffkqffnqdggkffnnfettfffuceophhlrghgnhhiohhjsehjtghrohhsohhfthdrtghomheqnecuffhomhgrihhnpeen X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeefjedrudefucetggdotefuucfrrhhofhhilhgvmecuqfggjfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgggtuggjfgesthdttfdttdervdenucfhrhhomheplfgvrghnqdevhhhrihhsthhophhhvgcurffntefipffkqffnqdggkffnnfettfffuceophhlrghgnhhiohhjsehjtghrohhsohhfthdrtghomheqnecuffhomhgrihhnpeen Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18:45 Mon 05 Dec , Alan Cox wrote: > > But as you illustrated, there is a large number of drivers that already > > assume no IRQ is < 0, even if they don't use any IRQ #0 themselves. > > That is a much bigger problem to fix. > > And a much larger number assuming the reverse is true which are hiding > potential bugs on ARM. > > Looking at the serial stuff the best checks appear to be looking at > "irq", "-1" and NO_IRQ. > > For migration stuff that's doing broken things like > > if (irq < 0) > > can be changed to > > if (irq <= 0) > > and that can be done before NO_IRQ itself is nailed on ARM and PA-RISC. can we sinply introduce a macro irq_is_valid and make it chip dependant as gpio_is_valid and then move away from irq 0 valid so we do not need to brake anthing first and then easly convert them Best Regards, J.