From: Borislav Petkov <bp@amd64.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Yu, Fenghua" <fenghua.yu@intel.com>,
H Peter Anvin <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
"Brown, Len" <len.brown@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH] x86/mcheck/therm_throt.c: Don't log power limit and package level thermal throttle event in mce log
Date: Tue, 6 Dec 2011 16:31:08 +0100 [thread overview]
Message-ID: <20111206153108.GD28735@gere.osrc.amd.com> (raw)
In-Reply-To: <0207C53569FE594381A4F2EB66570B2A018EE61884@orsmsx508.amr.corp.intel.com>
On Mon, Dec 05, 2011 at 02:18:26PM -0800, Luck, Tony wrote:
> This looks like a sane improvement, Tony I'm assuming you're handling this?
>
> I can push this - but it would be nice to have some other comments from
> outside of Intel (we've been beaten up written-by Intel, acked-by: Intel
> too many times).
>
> Can I count that as an "Acked-by:"?
Well, from looking at Udo's feedback here
http://marc.info/?l=linux-kernel&m=132206108724885
this patch looks like it helps in his case partially. I'm still not sure
about all the printks in therm_throt_process(), do you guys feel the
need to notify the user that the CPU clock was throttled/power limits
were applied, or rather have something more subtle...?
Hmmm.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2011-12-06 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 21:11 [PATCH] x86/mcheck/therm_throt.c: Don't log power limit and package level thermal throttle event in mce log Fenghua Yu
2011-12-05 13:18 ` Borislav Petkov
2011-12-05 22:18 ` Luck, Tony
2011-12-06 15:31 ` Borislav Petkov [this message]
2011-12-06 17:48 ` Yu, Fenghua
2011-12-06 19:06 ` Borislav Petkov
2011-12-06 19:26 ` Tony Luck
2011-12-06 19:56 ` Borislav Petkov
2011-12-06 19:27 ` Yu, Fenghua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206153108.GD28735@gere.osrc.amd.com \
--to=bp@amd64.org \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox