From: Greg KH <greg@kroah.com>
To: Ted Feng <artisdom@gmail.com>
Cc: Jiri Pirko <jpirko@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Josh Boyer <jwboyer@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] ipip, sit: copy parms.name after register_netdevice
Date: Tue, 6 Dec 2011 09:32:20 -0800 [thread overview]
Message-ID: <20111206173220.GA28763@kroah.com> (raw)
In-Reply-To: <CAM7b5hzt8D6hn3=XEcm9E3_BwJxj-YABpkufCpuhjiPLDxCsMQ@mail.gmail.com>
On Tue, Dec 06, 2011 at 05:25:24PM +0800, Ted Feng wrote:
> Same fix as 731abb9cb2 for ipip and sit tunnel.
> Commit 1c5cae815d removed an explicit call to dev_alloc_name in
> ipip_tunnel_locate
> and ipip6_tunnel_locate, because register_netdevice will now create a
> valid name.
> However the tunnel keeps a copy of the name in the private parms structure.
>
> This shows up if you do a simple tunnel add, followed by a tunnel show:
>
> $ sudo ip tunnel add mode ipip remote 10.2.20.211
> $ ip tunnel
> tunl0: ip/ip remote any local any ttl inherit nopmtudisc
> tunl%d: ip/ip remote 10.2.20.211 local any ttl inherit
> $ sudo ip tunnel add mode sit remote 10.2.20.212
> $ ip tunnel
> sit0: ipv6/ip remote any local any ttl 64 nopmtudisc 6rd-prefix 2002::/16
> sit%d: ioctl 89f8 failed: No such device
> sit%d: ipv6/ip remote 10.2.20.212 local any ttl inherit
>
> Signed-off-by: Ted Feng <artisdom@gmail.com>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2011-12-06 17:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 9:25 [PATCH] ipip, sit: copy parms.name after register_netdevice Ted Feng
2011-12-06 17:32 ` Greg KH [this message]
2011-12-08 3:35 ` Ted Feng
2011-12-08 4:16 ` Stephen Hemminger
2011-12-08 4:56 ` David Miller
2011-12-08 10:46 ` Ted Feng
2011-12-10 14:29 ` Ted Feng
2011-12-10 18:12 ` David Miller
2011-12-12 23:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206173220.GA28763@kroah.com \
--to=greg@kroah.com \
--cc=artisdom@gmail.com \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox