From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754827Ab1LFVtG (ORCPT ); Tue, 6 Dec 2011 16:49:06 -0500 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:35342 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754799Ab1LFVtD (ORCPT ); Tue, 6 Dec 2011 16:49:03 -0500 X-Sasl-enc: StQsMigZrno9YzG1DJeEpMZLsksPoDlrcpddK8VWjIhU 1323208142 Date: Tue, 6 Dec 2011 13:48:47 -0800 From: Greg KH To: Alan Stern Cc: "Rafael J. Wysocki" , NeilBrown , Ming Lei , Chen Peter-B29397 , Kernel development list , Linux-pm mailing list , "hzpeterchen@gmail.com" , Igor Grinberg Subject: Re: [PATCH] Driver core: leave runtime PM enabled during system shutdown Message-ID: <20111206214847.GH1247@kroah.com> References: <201112052332.10822.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 06, 2011 at 10:26:14AM -0500, Alan Stern wrote: > Disabling all runtime PM during system shutdown turns out not to be a > good idea, because some devices may need to be woken up from a > low-power state at that time. > > The whole point of disabling runtime PM for system shutdown was to > prevent untimely runtime-suspend method calls. This patch (as1504) > accomplishes the same result by incrementing the usage count for each > device and waiting for ongoing runtime-PM callbacks to finish. This > is what we already do during system suspend and hibernation, which > makes sense since the shutdown method is pretty much a legacy analog > of the pm->poweroff method. > > This fixes a regression on some OMAP systems. > > Signed-off-by: Alan Stern > Reported-by: NeilBrown > CC: Chen Peter-B29397 Acked-by: Greg Kroah-Hartman Rafael, you will take this in your tree, right?