From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, Andrew Vagin <avagin@openvz.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Kees Cook <keescook@chromium.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v2
Date: Wed, 7 Dec 2011 02:15:15 +0400 [thread overview]
Message-ID: <20111206221515.GP29781@moon> (raw)
In-Reply-To: <20111206140833.3b43fbeb.akpm@linux-foundation.org>
On Tue, Dec 06, 2011 at 02:08:33PM -0800, Andrew Morton wrote:
> On Mon, 5 Dec 2011 22:20:11 +0400
> Cyrill Gorcunov <gorcunov@openvz.org> wrote:
>
> > It helps to dump and restore this mm_struct members.
>
> Sorry, I'm not going to apply a patch with a changelog like that.
>
OK, I'll update it. The problem is that while we "read" this entries
from procfs, the restoration is supposed to be done via prctl interface
(the patch is in fly, and I'm trying to improve it at moment).
> It needs a full description of how this will be used and why it is
> needed. So that others can understand and evaluate the proposal, and
> any possible alternatives.
>
> Such a description would also let us see whether this is just some
> "hey, maybe we'll use this sometime" thing, in which case it should not
> yet be applied.
I understand.
>
> > fs/proc/array.c | 7 +++++--
>
> Also, every change to any procfs interface should have an associated
> change to procfs documentation. If no relevant document exists then
> heck, write one. No exceptions.
>
ok, thanks.
Cyrill
next prev parent reply other threads:[~2011-12-06 22:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 18:20 [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v2 Cyrill Gorcunov
2011-12-06 22:08 ` Andrew Morton
2011-12-06 22:15 ` Cyrill Gorcunov [this message]
2011-12-06 22:53 ` Cyrill Gorcunov
2011-12-06 23:22 ` Kees Cook
2011-12-07 6:31 ` Cyrill Gorcunov
2011-12-07 0:02 ` KAMEZAWA Hiroyuki
2011-12-07 6:33 ` Cyrill Gorcunov
2011-12-07 7:07 ` Cyrill Gorcunov
2011-12-12 7:30 ` Eric W. Biederman
2011-12-12 7:38 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206221515.GP29781@moon \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox