From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Greg KH <greg@kroah.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, NeilBrown <neilb@suse.de>,
Ming Lei <tom.leiming@gmail.com>,
"Chen Peter-B29397" <B29397@freescale.com>,
Kernel development list <linux-kernel@vger.kernel.org>,
"Linux-pm mailing list" <linux-pm@vger.kernel.org>,
"hzpeterchen@gmail.com" <hzpeterchen@gmail.com>,
Igor Grinberg <grinberg@compulab.co.il>
Subject: Re: [PATCH] Driver core: leave runtime PM enabled during system shutdown
Date: Tue, 6 Dec 2011 23:05:34 +0100 [thread overview]
Message-ID: <201112062305.34571.rjw@sisk.pl> (raw)
In-Reply-To: <20111206214847.GH1247@kroah.com>
On Tuesday, December 06, 2011, Greg KH wrote:
> On Tue, Dec 06, 2011 at 10:26:14AM -0500, Alan Stern wrote:
> > Disabling all runtime PM during system shutdown turns out not to be a
> > good idea, because some devices may need to be woken up from a
> > low-power state at that time.
> >
> > The whole point of disabling runtime PM for system shutdown was to
> > prevent untimely runtime-suspend method calls. This patch (as1504)
> > accomplishes the same result by incrementing the usage count for each
> > device and waiting for ongoing runtime-PM callbacks to finish. This
> > is what we already do during system suspend and hibernation, which
> > makes sense since the shutdown method is pretty much a legacy analog
> > of the pm->poweroff method.
> >
> > This fixes a regression on some OMAP systems.
> >
> > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> > Reported-by: NeilBrown <neilb@suse.de>
> > CC: Chen Peter-B29397 <B29397@freescale.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> Rafael, you will take this in your tree, right?
Yes, I will, thanks!
next prev parent reply other threads:[~2011-12-06 22:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 0:43 [PATCH 1/1] driver core: disable device's runtime pm during shutdown Peter Chen
2011-11-14 9:54 ` Ming Lei
2011-11-14 22:28 ` Rafael J. Wysocki
2011-11-14 22:27 ` Rafael J. Wysocki
2011-11-15 0:59 ` Greg KH
2011-11-15 23:16 ` Rafael J. Wysocki
2011-12-04 21:56 ` NeilBrown
2011-12-05 2:42 ` Alan Stern
2011-12-05 3:37 ` NeilBrown
2011-12-05 3:26 ` Ming Lei
2011-12-05 4:42 ` Chen Peter-B29397
2011-12-05 5:12 ` Ming Lei
2011-12-05 9:01 ` Ming Lei
2011-12-05 9:05 ` Ming Lei
2011-12-05 16:02 ` Alan Stern
2011-12-05 18:35 ` NeilBrown
2011-12-05 20:55 ` Alan Stern
2011-12-05 22:32 ` Rafael J. Wysocki
2011-12-06 15:26 ` [PATCH] Driver core: leave runtime PM enabled during system shutdown Alan Stern
2011-12-06 21:34 ` NeilBrown
2011-12-06 21:48 ` Greg KH
2011-12-06 22:05 ` Rafael J. Wysocki [this message]
2011-12-06 22:03 ` Rafael J. Wysocki
2011-12-05 4:53 ` [PATCH 1/1] driver core: disable device's runtime pm during shutdown NeilBrown
2011-12-05 5:53 ` Chen Peter-B29397
2011-12-05 8:08 ` NeilBrown
2011-12-05 8:32 ` Chen Peter-B29397
2011-12-05 8:52 ` NeilBrown
2011-12-05 3:29 ` Chen Peter-B29397
2011-12-05 5:09 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112062305.34571.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=B29397@freescale.com \
--cc=greg@kroah.com \
--cc=grinberg@compulab.co.il \
--cc=hzpeterchen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox