From: Al Viro <viro@ZenIV.linux.org.uk>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
LSM <linux-security-module@vger.kernel.org>,
LKLM <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] BTRFS: Establish i_ops before calling d_instantiate
Date: Wed, 7 Dec 2011 02:04:46 +0000 [thread overview]
Message-ID: <20111207020446.GU2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4EDEB5D6.4040202@schaufler-ca.com>
On Tue, Dec 06, 2011 at 04:39:50PM -0800, Casey Schaufler wrote:
> From: Casey Schaufler <casey@schaufler-ca.com>
>
> The Smack LSM hook for security_d_instantiate checks
> the inode's i_op->getxattr value to determine if the
[snip]
> + inode->i_op = &btrfs_special_inode_operations;
> +
> err = btrfs_add_nondir(trans, dir, dentry, inode, 0, index);
> if (err)
> drop_inode = 1;
> else {
> - inode->i_op = &btrfs_special_inode_operations;
> init_special_inode(inode, inode->i_mode, rdev);
> btrfs_update_inode(trans, root, inode);
To hell with LSM, there are much stronger reasons why d_instantiate() on
a half-baked inode is wrong. As soon as you've done it somebody can
come and look that dentry up.
IOW, the bug is real, but this patch is not enough - in particular, ->create()
part is simply wrong. We need to set ->a_ops before some joker comes and
tries to open it, at the very least...
prev parent reply other threads:[~2011-12-07 2:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 0:39 [PATCH] BTRFS: Establish i_ops before calling d_instantiate Casey Schaufler
2011-12-07 2:04 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207020446.GU2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=casey@schaufler-ca.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox