From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
Richard Purdie <rpurdie@rpsys.net>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Shreshtha Kumar Sahu <shreshthakumar.sahu@stericsson.com>
Subject: Re: [PATCH] leds: driver for ab5500 high voltage leds
Date: Wed, 7 Dec 2011 23:47:47 +0800 [thread overview]
Message-ID: <20111207154746.GA22355@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CACRpkdZBX6ct7GNz_5AEfqgnhS75OW9n+CFTzOXMYF8hV1fwOw@mail.gmail.com>
On Wed, Dec 07, 2011 at 03:16:06PM +0100, Linus Walleij wrote:
> Then in the sysfs interface:
> + if (led_curr > led->max_current)
> + led_curr = led->max_current;
> You are only allowed to set a lower value than the max value.
Oh, that's surprising - my expectation had been that the standard
brightness setting would be managing the current limit and the user
wouldn't need to control it separately.
next prev parent reply other threads:[~2011-12-07 15:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 13:56 [PATCH] leds: driver for ab5500 high voltage leds Linus Walleij
2011-12-03 21:49 ` Mark Brown
2011-12-07 14:16 ` Linus Walleij
2011-12-07 15:47 ` Mark Brown [this message]
2011-12-03 22:49 ` Denis Kuzmenko
2011-12-07 14:07 ` Linus Walleij
2011-12-07 18:01 ` Denis Kuzmenko
2011-12-08 0:00 ` Andrew Morton
2011-12-08 1:19 ` Mark Brown
2011-12-14 10:23 ` Shreshtha Kumar SAHU
2011-12-14 11:37 ` Mark Brown
2011-12-14 14:01 ` Shreshtha Kumar SAHU
2011-12-14 14:47 ` Mark Brown
2011-12-14 18:34 ` Linus Walleij
2011-12-15 7:11 ` Mark Brown
2011-12-16 5:10 ` Shreshtha Kumar SAHU
2011-12-22 17:43 ` Mark Brown
2011-12-19 11:26 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207154746.GA22355@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=shreshthakumar.sahu@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).