From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251Ab1LHOWw (ORCPT ); Thu, 8 Dec 2011 09:22:52 -0500 Received: from imr4.ericy.com ([198.24.6.9]:51513 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761Ab1LHOWv (ORCPT ); Thu, 8 Dec 2011 09:22:51 -0500 Date: Thu, 8 Dec 2011 06:20:52 -0800 From: Guenter Roeck To: Axel Lin CC: "linux-kernel@vger.kernel.org" , Lars-Peter Clausen , Jean Delvare , "lm-sensors@lm-sensors.org" Subject: Re: [PATCH 1/2] hwmon: jz4740: fix signedness bug Message-ID: <20111208142052.GA8163@ericsson.com> References: <1323349452.2823.1.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1323349452.2823.1.camel@phoenix> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 08, 2011 at 08:04:12AM -0500, Axel Lin wrote: > wait_for_completion_interruptible_timeout() may return negative value. > In this case, checking if (t > 0) will return true if t is unsigned. > > Signed-off-by: Axel Lin Applied. Thanks, Guenter