From: Jason Baron <jbaron@redhat.com>
To: Rusty Russell <rusty@ozlabs.org>
Cc: jim.cromie@gmail.com, greg@kroah.com, joe@perches.com,
bart.vanassche@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 21/25] kernel/module: replace DEBUGP with pr_debug
Date: Thu, 8 Dec 2011 10:41:28 -0500 [thread overview]
Message-ID: <20111208154127.GB2499@redhat.com> (raw)
In-Reply-To: <87zkf5i3yv.fsf@rustcorp.com.au>
On Wed, Dec 07, 2011 at 11:37:52AM +1030, Rusty Russell wrote:
> On Tue, 6 Dec 2011 12:11:31 -0700, jim.cromie@gmail.com wrote:
> > From: Jim Cromie <jim.cromie@gmail.com>
> >
> > Use more flexible pr_debug. This allows:
> >
> > echo "module module +p" > /dbg/dynamic_debug/control
> >
> > to turn on debug messages when needed.
> >
> > Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> > ---
> > kernel/module.c | 44 +++++++++++++++++++-------------------------
> > kernel/params.c | 14 ++++----------
> > 2 files changed, 23 insertions(+), 35 deletions(-)
>
> Split into 2 and applied. This is a win, independent of the rest.
>
Probably also want to pick up patch 1 in the series too, which actually allows
this one to build ;)
Thanks,
-Jason
next prev parent reply other threads:[~2011-12-08 15:41 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 20:27 [patch 00/25] dynamic-debug enhancements Jim Cromie
2011-12-06 18:59 ` Jim Cromie
2011-12-06 19:11 ` [patch 00/24 ] dynamic debug enhancements: multi-queries during mod-init jim.cromie
2011-12-06 19:11 ` [PATCH 01/25] kernel/module.c: fix compile err, warnings under ifdef DEBUGP jim.cromie
2011-12-06 19:11 ` [PATCH 02/25] dynamic_debug: fix whitespace complaints from scripts/cleanfile jim.cromie
2011-12-06 19:11 ` [PATCH 03/25] dynamic_debug: drop enabled field from struct _ddebug, use _DPRINTK_FLAGS_PRINT jim.cromie
2011-12-06 19:11 ` [PATCH 04/25] dynamic_debug: make dynamic-debug supersede DEBUG ccflag jim.cromie
2011-12-06 19:11 ` [PATCH 05/25] dynamic_debug: change verbosity at runtime jim.cromie
2011-12-06 19:11 ` [PATCH 06/25] dynamic_debug: replace strcpy with strlcpy, in ddebug_setup_query() jim.cromie
2011-12-06 19:11 ` [PATCH 07/25] dynamic_debug: pr_err() call should not depend upon verbosity jim.cromie
2011-12-06 19:11 ` [PATCH 08/25] dynamic_debug: drop explicit !=NULL checks jim.cromie
2011-12-06 19:11 ` [PATCH 09/25] dynamic_debug: describe_flags with '=[pmflt_]*' jim.cromie
2011-12-06 19:11 ` [PATCH 10/25] dynamic_debug: tighten up error checking on debug queries jim.cromie
2011-12-06 19:11 ` [PATCH 11/25] dynamic_debug: early return if _ddebug table is empty jim.cromie
2011-12-06 19:11 ` [PATCH 12/25] dynamic_debug: reduce lineno field to a saner 18 bits jim.cromie
2011-12-06 19:11 ` [PATCH 13/25] dynamic_debug: chop off comments in ddebug_tokenize jim.cromie
2011-12-06 19:11 ` [PATCH 14/25] dynamic_debug: enlarge command/query write buffer jim.cromie
2011-12-06 19:11 ` [PATCH 15/25] dynamic_debug: add trim_prefix() to provide source-root relative paths jim.cromie
2011-12-06 19:11 ` [PATCH 16/25] dynamic_debug: factor vpr_info_dq out of ddebug_parse_query jim.cromie
2011-12-06 19:11 ` [PATCH 17/25] dynamic_debug: process multiple debug-queries on a line jim.cromie
2011-12-06 19:11 ` [PATCH 18/25] dynamic_debug: Introduce global fake module param $module.dyndbg jim.cromie
2011-12-07 1:01 ` Rusty Russell
2011-12-07 8:33 ` Jim Cromie
2011-12-07 10:59 ` Rusty Russell
2011-12-08 17:10 ` Jason Baron
2011-12-08 18:12 ` Jim Cromie
2011-12-06 19:11 ` [PATCH 19/25] pnp: if CONFIG_DYNAMIC_DEBUG, use pnp.dyndbg instead of pnp.debug jim.cromie
2011-12-06 19:11 ` [PATCH 20/25] dynamic_debug: add modname arg to exec_query callchain jim.cromie
2011-12-06 19:11 ` [PATCH 21/25] kernel/module: replace DEBUGP with pr_debug jim.cromie
2011-12-07 1:07 ` Rusty Russell
2011-12-08 15:41 ` Jason Baron [this message]
2011-12-08 18:17 ` Jim Cromie
2011-12-06 19:11 ` [PATCH 22/25] dynamic_debug: protect "dyndbg" fake module param name at compile-time jim.cromie
2011-12-06 19:11 ` [PATCH 23/25] dynamic_debug: update Documentation/kernel-parameters.txt, Kconfig.debug jim.cromie
2011-12-06 19:11 ` [PATCH 24/25] dynamic_debug: remove unneeded includes jim.cromie
2011-12-12 22:05 ` [patch 00/24 ] dynamic debug enhancements: multi-queries during mod-init Greg KH
[not found] ` <CAJfuBxzeKzmOCo00Ew8xAp9EmU0QZ3zjOkRcdEMzYrtx_b9+kA@mail.gmail.com>
2011-12-13 4:17 ` Jim Cromie
2011-12-13 4:25 ` Greg KH
2011-12-13 7:00 ` Jim Cromie
2011-12-13 7:44 ` Greg KH
2011-12-13 14:48 ` Jason Baron
2011-12-12 23:12 ` [patch 00/23] dynamic-debug enhancements Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208154127.GB2499@redhat.com \
--to=jbaron@redhat.com \
--cc=bart.vanassche@gmail.com \
--cc=greg@kroah.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox