From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752346Ab1LHRBZ (ORCPT ); Thu, 8 Dec 2011 12:01:25 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:15658 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750763Ab1LHRBX (ORCPT ); Thu, 8 Dec 2011 12:01:23 -0500 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/b3fTWySA+nJyARISCEdL/ Date: Thu, 8 Dec 2011 09:01:14 -0800 From: Tony Lindgren To: Ohad Ben-Cohen Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, akpm@linux-foundation.org, Brian Swetland , Arnd Bergmann , Grant Likely , Rusty Russell , Russell King , Greg KH , Stephen Boyd Subject: Re: [PATCH 4/7] amp/omap: add a remoteproc driver Message-ID: <20111208170114.GZ31337@atomide.com> References: <1319536106-25802-1-git-send-email-ohad@wizery.com> <1319536106-25802-5-git-send-email-ohad@wizery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ohad Ben-Cohen [111207 23:26]: > Hi Tony, > > On Tue, Oct 25, 2011 at 11:48 AM, Ohad Ben-Cohen wrote: > > Add a remoteproc driver for OMAP4, so we can boot the dual-M3 "Ducati" > > and DSP subsystems. > > > > Use the omap_device_* API to control the hardware state, and utilize > > the OMAP mailbox to interrupt the remote processor when a new message > > is pending (the mailbox payload is used to tell it which virtqueue was > > the message placed in). > > > > Conversely, when an inbound mailbox message arrives, tell the remoteproc > > core which virtqueue is triggered. > > > > Later we will also use the mailbox payload to signal omap-specific > > events like remote crashes (which will be used to trigger remoteproc > > recovery) and power management transitions. At that point we will also > > extend the remoteproc core to support this. > > > > Based on (but now quite far from) work done by Fernando Guzman Lugo > > and Hari Kanigeri . > > > > Designed with Brian Swetland . > > > > Signed-off-by: Ohad Ben-Cohen > > Cc: Brian Swetland > > Cc: Arnd Bergmann > > Cc: Grant Likely > > Cc: Tony Lindgren > > Cc: Russell King > > Cc: Rusty Russell > > Cc: Andrew Morton > > Cc: Greg KH > > Cc: Stephen Boyd > > --- > >  arch/arm/plat-omap/include/plat/remoteproc.h |   56 ++++++ > >  drivers/amp/remoteproc/Kconfig               |   21 +++ > >  drivers/amp/remoteproc/Makefile              |    4 +- > >  drivers/amp/remoteproc/omap_remoteproc.c     |  248 ++++++++++++++++++++++++++ > >  drivers/amp/remoteproc/omap_remoteproc.h     |   69 +++++++ > >  5 files changed, 397 insertions(+), 1 deletions(-) > >  create mode 100644 arch/arm/plat-omap/include/plat/remoteproc.h > >  create mode 100644 drivers/amp/remoteproc/omap_remoteproc.c > >  create mode 100644 drivers/amp/remoteproc/omap_remoteproc.h > > I'm about to add this to linux-next (minus the 'amp' wording); can I > please have your Acked-by for this (at least for the plat-omap change) ? The platform init code looks OK to me. Please also start considering how to do the DT bindings for it. For patches 4 & 5: Acked-by: Tony Lindgren