From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jason Baron <jbaron@redhat.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: [RFC][PATCH 0/3] x86: Find a way to allow breakpoints in NMIs
Date: Thu, 08 Dec 2011 14:30:03 -0500 [thread overview]
Message-ID: <20111208193003.112037550@goodmis.org> (raw)
As been previously discussed on LKML, x86 has an issue with NMIs and iret.
If an NMI takes an exception or breakpoint, iret that those handlers do
will take the CPU out of NMI context, which could allow another NMI to
come in and corrupt the stack.
Linus has discussed a way to solve this and I tried to implement it.
What I came up with was a bit different, but I'm posting it now to get
some feedback from it. See patch 3. I wrote a very detailed change log
there and wont repeat it here.
Let me know what everyone thinks.
Thanks!
-- Steve
---
Linus Torvalds (1):
x86: Do not schedule while still in NMI context
Steven Rostedt (2):
x86: Document the NMI handler about not using paranoid_exit
x86: Add workaround to NMI iret woes
----
arch/x86/kernel/entry_64.S | 209 +++++++++++++++++++++++++++++++++++++-------
1 files changed, 176 insertions(+), 33 deletions(-)
next reply other threads:[~2011-12-08 19:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 19:30 Steven Rostedt [this message]
2011-12-08 19:30 ` [RFC][PATCH 1/3] x86: Do not schedule while still in NMI context Steven Rostedt
2011-12-08 19:30 ` [RFC][PATCH 2/3] x86: Document the NMI handler about not using paranoid_exit Steven Rostedt
2011-12-08 19:30 ` [RFC][PATCH 3/3] x86: Add workaround to NMI iret woes Steven Rostedt
2011-12-08 19:36 ` Steven Rostedt
2011-12-09 2:43 ` Steven Rostedt
2011-12-09 9:22 ` Peter Zijlstra
2011-12-09 15:00 ` Steven Rostedt
2011-12-09 15:10 ` Peter Zijlstra
2011-12-09 15:25 ` Steven Rostedt
2011-12-09 15:20 ` Steven Rostedt
2011-12-09 16:34 ` Steven Rostedt
2011-12-09 17:19 ` Steven Rostedt
2011-12-09 17:49 ` Borislav Petkov
2011-12-09 18:20 ` Steven Rostedt
2011-12-09 16:49 ` Jason Baron
2011-12-09 17:14 ` Steven Rostedt
2011-12-09 12:40 ` Mathieu Desnoyers
2011-12-09 13:02 ` Mathieu Desnoyers
2011-12-09 14:49 ` Steven Rostedt
2011-12-09 15:02 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208193003.112037550@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox