From: Greg KH <greg@kroah.com>
To: Ravishankar karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/30] Staging: comedi: fix printk issue in daqboard2000.c
Date: Thu, 8 Dec 2011 16:00:48 -0800 [thread overview]
Message-ID: <20111209000048.GA31036@kroah.com> (raw)
In-Reply-To: <1323348745-31477-3-git-send-email-ravishankar.km@greenturtles.in>
On Thu, Dec 08, 2011 at 06:21:58PM +0530, Ravishankar karkala Mallikarjunayya wrote:
> This is a patch to the daqboard2000.c file that fixes up a
> printk warning found by the checkpatch.pl tool.
>
> Converted printks to pr_<levels>.
>
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
> ---
> drivers/staging/comedi/drivers/daqboard2000.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/daqboard2000.c b/drivers/staging/comedi/drivers/daqboard2000.c
> index a16060e..265c650 100644
> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -502,7 +502,7 @@ static int daqboard2000_ao_insn_write(struct comedi_device *dev,
>
> static void daqboard2000_resetLocalBus(struct comedi_device *dev)
> {
> - printk("daqboard2000_resetLocalBus\n");
> + pr_debug("daqboard2000_resetLocalBus\n");
What's wrong with dev_dbg()? Please use the dev_* functions wherever
possible, like here and in all of the other printk patches you sent.
thanks,
greg k-h
next prev parent reply other threads:[~2011-12-09 0:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 12:51 [PATCH 01/30] Staging: comedi: fix initialise statics to 0 or NULL issue in cb_das16_cs.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:51 ` [PATCH 02/30] Staging: comedi: fix brace coding style issue in daqboard2000.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:51 ` [PATCH 03/30] Staging: comedi: fix printk " Ravishankar karkala Mallikarjunayya
2011-12-09 0:00 ` Greg KH [this message]
2011-12-08 12:51 ` [PATCH 04/30] " Ravishankar karkala Mallikarjunayya
2011-12-09 0:01 ` Greg KH
2011-12-08 12:52 ` [PATCH 05/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 06/30] Staging: comedi: fix printk line over 80 character " Ravishankar karkala Mallikarjunayya
2011-12-09 0:01 ` Greg KH
2011-12-08 12:52 ` [PATCH 07/30] Staging: comedi: fix printk issue in cb_pcimdda.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 08/30] Staging: comedi: fix line over 80 character " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 09/30] Staging: comedi: fix printk issue in pcmuio.c Ravishankar karkala Mallikarjunayya
2011-12-08 13:29 ` Hans J. Koch
2011-12-08 12:52 ` [PATCH 10/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 11/30] Staging: comedi: fix printk issue in cb_pcimdas.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 12/30] Staging: comedi: fix printk issue in contec_pci_dio.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 13/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 14/30] Staging: comedi: fix initialise statics to 0 or NULL issue in dt3000.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 15/30] Staging: comedi: fix printk " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 16/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 17/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 18/30] Staging: comedi: fix printk issue in jr3_pci.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 19/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 20/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 21/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 22/30] Staging: comedi: fix brace coding style issue in ni_at_a2150.c Ravishankar karkala Mallikarjunayya
2011-12-09 0:03 ` Greg KH
2011-12-08 12:52 ` [PATCH 23/30] " Ravishankar karkala Mallikarjunayya
2011-12-09 0:03 ` Greg KH
2011-12-08 12:52 ` [PATCH 24/30] Staging: comedi: fix brace coding style issue in cb_pcidda.c Ravishankar karkala Mallikarjunayya
2011-12-09 0:03 ` Greg KH
2011-12-08 12:52 ` [PATCH 25/30] Staging: comedi: fix printk issue in cb_pcidas.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 26/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 27/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 28/30] Staging: comedi: fix printk issue in cb_pcidas64.c Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 29/30] " Ravishankar karkala Mallikarjunayya
2011-12-08 12:52 ` [PATCH 30/30] Staging: comedi: fix printk issue in das1800.c Ravishankar karkala Mallikarjunayya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209000048.GA31036@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankar.km@greenturtles.in \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox