RE: [PATCHv2 01/10] xshm: Shared Memory layout for ST-E M7400 driver.

Sjur BRENDELAND
2011-12-12T09:09:44Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 905 bytes --]

Hi Arnd,

> > include/linux/xshm/xshm_ipctoc.h | 160
> ++++++++++++++++++++++++++++++++++++++
> > 1 files changed, 160 insertions(+), 0 deletions(-)
> > create mode 100644 include/linux/xshm/xshm_ipctoc.h
>
> Generally, the include/linux path is for interfaces between modules, while
> hardware data structures should be in the same directory as the driver using
> them to provide an abstract interface.

Sure, I'll move this file to drivers/xshm.

> > +#pragma pack(1)
>
> Better remove the #pragma. Marking data structures as packed when they
> are already packed to start with only leads to worse optimizations in the
> compiler, but does not have a functional impact.

Ok, I'll remove the #pragma in the next patch-set.

Regards,
Sjur
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥