From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: mchehab@infradead.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] uvcvideo: Use kcalloc instead of kzalloc to allocate array
Date: Mon, 12 Dec 2011 00:41:54 +0100 [thread overview]
Message-ID: <201112120041.54884.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <1322600880.1534.315.camel@localhost.localdomain>
Hi Thomas,
Thanks for the patch.
On Tuesday 29 November 2011 22:08:00 Thomas Meyer wrote:
> The advantage of kcalloc is, that will prevent integer overflows which
> could result from the multiplication of number of elements and size and it
> is also a bit nicer to read.
>
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Should I take the patch in my tree, or do you plan to push several similar
patches directly in one go ?
> ---
>
> diff -u -p a/drivers/media/video/uvc/uvc_ctrl.c
> b/drivers/media/video/uvc/uvc_ctrl.c ---
> a/drivers/media/video/uvc/uvc_ctrl.c 2011-11-28 19:36:47.613437745 +0100
> +++ b/drivers/media/video/uvc/uvc_ctrl.c 2011-11-28 19:58:26.309317018
> +0100 @@ -1861,7 +1861,7 @@ int uvc_ctrl_init_device(struct uvc_devi
> if (ncontrols == 0)
> continue;
>
> - entity->controls = kzalloc(ncontrols * sizeof(*ctrl),
> + entity->controls = kcalloc(ncontrols, sizeof(*ctrl),
> GFP_KERNEL);
> if (entity->controls == NULL)
> return -ENOMEM;
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2011-12-11 23:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 21:08 [PATCH] [media] uvcvideo: Use kcalloc instead of kzalloc to allocate array Thomas Meyer
2011-12-11 23:41 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112120041.54884.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox