From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>, sameo@linux.intel.com
Cc: linux-kernel@vger.kernel.org, Dajun <dajun.chen@diasemi.com>,
arnd@arndb.de, linaro-dev@lists.linaro.org, eric.miao@linaro.org
Subject: Re: [PATCH 03/06] MFD: DA9052/53 MFD core module v9 Added SPI support
Date: Mon, 12 Dec 2011 13:01:13 +0800 [thread overview]
Message-ID: <20111212050111.GC3216@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1323440193.23171.71.camel@dhruva>
On Fri, Dec 09, 2011 at 07:46:33PM +0530, Ashish Jangam wrote:
> The DA9052/53 is a highly integrated PMIC subsystem with supply domain
> flexibility to support wide range of high performance application.
Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Looks good, though again you should've CCed Samuel. One small thing:
>
> struct device *dev;
> + struct spi_device *spi_dev;
> struct i2c_client *i2c_client;
You con't actually use this (or the i2c_client) any more so could just
drop them.
prev parent reply other threads:[~2011-12-12 5:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 14:16 [PATCH 03/06] MFD: DA9052/53 MFD core module v9 Added SPI support Ashish Jangam
2011-12-12 5:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212050111.GC3216@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=ashish.jangam@kpitcummins.com \
--cc=dajun.chen@diasemi.com \
--cc=eric.miao@linaro.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox