From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Andrew Vagin <avagin@openvz.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Kees Cook <keescook@chromium.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v2
Date: Mon, 12 Dec 2011 11:38:36 +0400 [thread overview]
Message-ID: <20111212073836.GB2199@moon> (raw)
In-Reply-To: <m1boreckmq.fsf@fess.ebiederm.org>
On Sun, Dec 11, 2011 at 11:30:21PM -0800, Eric W. Biederman wrote:
> Cyrill Gorcunov <gorcunov@gmail.com> writes:
>
> > On Wed, Dec 07, 2011 at 10:33:08AM +0400, Cyrill Gorcunov wrote:
> >>
> >> No problem, I'll update (These segments are filled by binfmt handlers).
> >>
> >
> > This one should fit.
>
> How extensively have you tested this. I remember a few other occasions
> where adding elements to a line in a proc file have resulted in breaking
> readers.
>
Hmm. Tested it pretty heavy on centos 5 series. I'll dig some more.
> I expect it is much safer to add this to /proc/<pid>/status rather than
> /proc/<pid>/stat.
>
Eric, I'm fine with any file. I thought about /.../stat only because it
already has start_code/end_code, so to have all pieces in one place this
file was choosen.
Cyrill
prev parent reply other threads:[~2011-12-12 7:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 18:20 [PATCH] fs, proc: Add start_data, end_data, start_brk members to /proc/$pid/stat v2 Cyrill Gorcunov
2011-12-06 22:08 ` Andrew Morton
2011-12-06 22:15 ` Cyrill Gorcunov
2011-12-06 22:53 ` Cyrill Gorcunov
2011-12-06 23:22 ` Kees Cook
2011-12-07 6:31 ` Cyrill Gorcunov
2011-12-07 0:02 ` KAMEZAWA Hiroyuki
2011-12-07 6:33 ` Cyrill Gorcunov
2011-12-07 7:07 ` Cyrill Gorcunov
2011-12-12 7:30 ` Eric W. Biederman
2011-12-12 7:38 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212073836.GB2199@moon \
--to=gorcunov@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=ebiederm@xmission.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segoon@openwall.com \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox