public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Donggeun Kim <dg77.kim@samsung.com>
Cc: sameo@linux.intel.com, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] MFD: MAX77693: add MAX77693 MFD driver
Date: Mon, 12 Dec 2011 17:48:28 +0800	[thread overview]
Message-ID: <20111212094827.GA31568@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4EE5C330.8060902@samsung.com>

On Mon, Dec 12, 2011 at 06:02:40PM +0900, Donggeun Kim wrote:
> On 2011년 12월 09일 18:58, Mark Brown wrote:
> > On Fri, Dec 09, 2011 at 06:15:39PM +0900, Donggeun Kim wrote:

> >> +	if (max77693_read_reg(i2c, MAX77693_PMIC_REG_PMIC_ID2, &reg_data) < 0) {

> > I'd suggest also verifying that the ID register has the expected value.
> > If there's a chip reision register logging it can be helpful.

> The all expected values for the register are not specified at datasheet.
> The perpose of the read function is simply checking the existence of the
> device so that the following operations are stopped for error case.

With a name like "ID" it's clearly chip idenfication - you should at
least be displaying the value if it might change as it's likely to be
useful for diagnostics.

  reply	other threads:[~2011-12-12  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09  9:15 [PATCH 0/2] MFD: MAX77693: add initial MAX77693 MFD driver Donggeun Kim
2011-12-09  9:15 ` [PATCH 1/2] MFD: MAX77693: add " Donggeun Kim
2011-12-09  9:58   ` Mark Brown
2011-12-12  9:02     ` Donggeun Kim
2011-12-12  9:48       ` Mark Brown [this message]
2011-12-12 10:03         ` Donggeun Kim
2011-12-09  9:15 ` [PATCH 2/2] MFD: MAX77693: add IRQ handler Donggeun Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111212094827.GA31568@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=dg77.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox