From: Samuel Ortiz <sameo@linux.intel.com>
To: Viresh Kumar <viresh.kumar@st.com>
Cc: Rabin Vincent <rabin@rab.in>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Armando VISCONTI <armando.visconti@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Vipin KUMAR <vipin.kumar@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Deepak SIKRI <deepak.sikri@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Pratyush ANAND <pratyush.anand@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Bhavna YADAV <bhavna.yadav@st.com>,
Vincenzo FRASCINO <Vincenzo.FRASCINO@st.com>,
Mirko GARDI <mirko.gardi@st.com>,
Srinidhi KASAGAR <srinidhi.kasagar@stericsson.com>
Subject: Re: [PATCH 0/2] mfd/stmpe: Add SPI interface support
Date: Mon, 12 Dec 2011 12:36:17 +0100 [thread overview]
Message-ID: <20111212113617.GA13952@sortiz-mobl> (raw)
In-Reply-To: <4EBD08E7.3080608@st.com>
Hi Viresh,
On Fri, Nov 11, 2011 at 05:07:11PM +0530, Viresh Kumar wrote:
> On 11/11/2011 5:02 PM, Rabin Vincent wrote:
> > On Fri, Nov 11, 2011 at 15:59, Viresh Kumar <viresh.kumar@st.com> wrote:
> >> On 11/11/2011 3:13 PM, Rabin Vincent wrote:
> >>> Could you instead convert stmpe to use the register map API, and then
> >>> add the SPI interface? Converting to regmap should both simplify the
> >>> existing code as well as make it possible to add the second interface
> >>> with fewer lines of code.
> >>
> >> Sorry Rabin, but i couldn't get your comment completely. :(
> >> Can you please spend few lines on "what do you mean by register map API"?
> >
> > drivers/base/regmap, added in b83a313bf25 ("regmap: Add generic
> > non-memory mapped register access API").
> >
> > Several MFDs are already using it (git grep regmap drivers/mfd/), and
> > patches to convert more are making the rounds on the lists.
>
> Ok. Got it now. :)
>
> Can we get this patchset pushed as it is and i will do this regmap stuff
> later in a separate patchset? Actually i am a bit busy currently with
> some other activities and can come back to it after some time.
Ok, but I really hope you will be able to get back at it. I applied your
patchset to my for-next branch for now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2011-12-12 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 7:05 [PATCH 0/2] mfd/stmpe: Add SPI interface support Viresh Kumar
2011-11-08 7:05 ` [PATCH 1/2] mfd/stmpe: separate out controller and interface specific code Viresh Kumar
2011-11-08 7:05 ` [PATCH 2/2] mfd/stmpe: Add support for SPI interface Viresh Kumar
2011-11-08 8:43 ` [PATCH 0/2] mfd/stmpe: Add SPI interface support Linus Walleij
2011-11-11 9:43 ` Rabin Vincent
2011-11-11 10:29 ` Viresh Kumar
2011-11-11 11:32 ` Rabin Vincent
2011-11-11 11:37 ` Viresh Kumar
2011-12-12 11:36 ` Samuel Ortiz [this message]
2011-12-12 11:48 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212113617.GA13952@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=Amit.VIRDI@st.com \
--cc=Vincenzo.FRASCINO@st.com \
--cc=armando.visconti@st.com \
--cc=bhavna.yadav@st.com \
--cc=bhupesh.sharma@st.com \
--cc=deepak.sikri@st.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mirko.gardi@st.com \
--cc=pratyush.anand@st.com \
--cc=rabin@rab.in \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox