From: Andrew Morton <akpm@linux-foundation.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: roel <roel.kluin@gmail.com>, LKML <linux-kernel@vger.kernel.org>,
sage@newdream.net, Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
fuse-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org
Subject: Re: ceph, cifs, nfs, fuse: boolean and / or confusion
Date: Mon, 12 Dec 2011 15:54:23 -0800 [thread overview]
Message-ID: <20111212155423.24543d6a.akpm@linux-foundation.org> (raw)
In-Reply-To: <1323733511.13849.19.camel@lade.trondhjem.org>
On Mon, 12 Dec 2011 18:45:11 -0500
Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> On Mon, 2011-12-12 at 18:39 -0500, Trond Myklebust wrote:
>
> > As far as NFS is concerned, it reverts a regression. NFS only used to
> > run revalidate_file_size() for SEEK_END prior to commit
> > 06222e491e663dac939f04b125c9dc52126a75c4. I accept that we now also need
> > to run it for SEEK_HOLE and SEEK_DATA, but we've never had to do so for
> > SEEK_SET and SEEK_CUR.
>
> BTW: The regression exists in 3.1, so this is probably a stable
> candidate...
>
I'd prefer not to merge this one unless all four fs maintainers have
reviewed and preferably tested it. Also, in view of your earlier email
the changelog for this patch needs updating for NFS and probably other
filesystems.
So please prepare and send the NFS patch, with a Reported-by:roel?
next prev parent reply other threads:[~2011-12-12 23:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 23:06 ceph, cifs, nfs, fuse: boolean and / or confusion roel
2011-12-12 23:28 ` Andrew Morton
2011-12-12 23:39 ` Trond Myklebust
2011-12-12 23:45 ` Trond Myklebust
2011-12-12 23:54 ` Andrew Morton [this message]
2011-12-13 5:29 ` Sage Weil
2011-12-13 11:25 ` Miklos Szeredi
2011-12-13 14:34 ` Jeff Layton
2011-12-12 23:44 ` drivers/crypto/picoxcell_crypto.c: " Joe Perches
2011-12-12 23:55 ` drivers/media/video/s5p-fimc/fimc-capture.c: " Joe Perches
2011-12-13 14:26 ` Sylwester Nawrocki
2011-12-13 9:50 ` drivers/crypto/picoxcell_crypto.c: " Jamie Iles
2011-12-13 0:02 ` drivers/scsi/bfa/bfa_fcpim.c: " Joe Perches
2011-12-13 0:45 ` Jing Huang
2011-12-13 0:14 ` drivers/dma/sirf-dma.c: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212155423.24543d6a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Trond.Myklebust@netapp.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=roel.kluin@gmail.com \
--cc=sage@newdream.net \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox