From: Greg KH <greg@kroah.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: gregkh@suse.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, ostrikov@nvidia.com,
adobriyan@gmail.com, eric.dumazet@gmail.com, mingo@elte.hu
Subject: Re: [PATCH 1/3] kref: Inline all functions
Date: Mon, 12 Dec 2011 14:11:59 -0800 [thread overview]
Message-ID: <20111212221159.GA27940@kroah.com> (raw)
In-Reply-To: <20111210104840.107647845@chello.nl>
On Sat, Dec 10, 2011 at 11:43:42AM +0100, Peter Zijlstra wrote:
> These are tiny functions, there's no point in having them out-of-line.
Nice, but this breaks the build:
CC init/main.o
In file included from include/linux/kobject.h:24:0,
from include/linux/module.h:16,
from init/main.c:13:
include/linux/kref.h: In function ‘kref_put’:
include/linux/kref.h:62:2: error: ‘kfree’ undeclared (first use in this function)
include/linux/kref.h:62:2: note: each undeclared identifier is reported only once for each function it appears in
include/linux/kref.h: In function ‘kref_sub’:
include/linux/kref.h:91:2: error: ‘kfree’ undeclared (first use in this function)
make[1]: *** [init/main.o] Error 1
make: *** [init] Error 2
Sorry, I can't apply this.
This was on an x86-64 build, my "stock" desktop system, nothing "odd" in the
config at all...
greg k-h
next prev parent reply other threads:[~2011-12-12 22:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 10:43 [PATCH 0/3] kref: inline and barriers Peter Zijlstra
2011-12-10 10:43 ` [PATCH 1/3] kref: Inline all functions Peter Zijlstra
2011-12-10 14:32 ` Ming Lei
2011-12-10 14:59 ` Peter Zijlstra
2011-12-12 22:11 ` Greg KH [this message]
2011-12-13 9:36 ` Peter Zijlstra
2011-12-13 17:15 ` Greg KH
2011-12-13 18:52 ` Peter Zijlstra
2011-12-13 19:11 ` Greg KH
2011-12-13 19:36 ` Peter Zijlstra
2011-12-10 10:43 ` [PATCH 2/3] kref: Implement kref_put in terms of kref_sub Peter Zijlstra
2011-12-10 10:43 ` [PATCH 3/3] kref: Remove the memory barriers Peter Zijlstra
2011-12-10 14:07 ` Ming Lei
2011-12-10 14:58 ` Peter Zijlstra
2011-12-10 15:57 ` Ming Lei
2011-12-10 19:49 ` Peter Zijlstra
2011-12-11 2:22 ` Ming Lei
2011-12-11 12:47 ` Peter Zijlstra
2011-12-11 12:59 ` Ming Lei
2011-12-11 15:35 ` Peter Zijlstra
2011-12-11 20:42 ` Peter Zijlstra
2011-12-12 3:48 ` Ming Lei
2011-12-12 8:54 ` Peter Zijlstra
2011-12-12 9:57 ` Ming Lei
2011-12-12 10:12 ` Peter Zijlstra
2011-12-12 10:32 ` Ming Lei
2011-12-12 11:05 ` Peter Zijlstra
2011-12-12 11:19 ` Ming Lei
2011-12-12 11:13 ` Eric Dumazet
2011-12-12 11:15 ` Oliver Neukum
2011-12-12 10:20 ` Oliver Neukum
2011-12-12 19:30 ` Greg KH
2011-12-12 22:56 ` Oliver Neukum
2011-12-12 23:14 ` Greg KH
2011-12-13 11:51 ` Oliver Neukum
2011-12-13 9:12 ` Peter Zijlstra
2011-12-13 9:49 ` Oliver Neukum
2011-12-12 8:55 ` Peter Zijlstra
2011-12-12 15:24 ` Greg KH
2011-12-12 8:56 ` Peter Zijlstra
2011-12-12 10:10 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212221159.GA27940@kroah.com \
--to=greg@kroah.com \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ostrikov@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox