From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Mike Frysinger <vapier@gentoo.org>,
qi.wang@intel.com, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, yong.y.wang@intel.com,
kok.howg.ewe@intel.com, Daniel Mack <zonque@gmail.com>,
Liam Girdwood <lrg@ti.com>,
joel.clark@intel.com
Subject: Re: [alsa-devel] [PATCH 3/3] sound/soc/lapis: add platform driver
Date: Tue, 13 Dec 2011 12:59:59 +0800 [thread overview]
Message-ID: <20111213045958.GC4565@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CANKRQng7AgKLYGSbBMbOiWifL6WNPHM=b7cB0FhfuXg74qi1Fg@mail.gmail.com>
On Tue, Dec 13, 2011 at 01:38:25PM +0900, Tomoya MORINAGA wrote:
> 2011/12/12 Mark Brown <broonie@opensource.wolfsonmicro.com>:
> > The latter. With things like this it would be *really* helpful if you
> > could take a step back and think about what the differences mean and why
> > they are different.
> Our driver needs ".pointer" method.
> However, "struct snd_soc_dai_ops" doesn't have the method.
> So, I think "struct snd_soc_dai_ops" cannot be applied to our driver.
What makes you claim this - *why* does your DAI driver need a pointer
method?
> Searching other drivers, "blackfin/bf5xx-i2s-pcm.c" uses "struct
> snd_soc_ops" not "struct snd_soc_dai_ops".
> Let me know your opinion.
Of course the DMA driver uses the ops for DMA drivers! Alternatively if
your question above is about your DMA driver then why is your DMA driver
using DAI ops?
To repeat what I said above in a different way *please* put more effort
into understanding things and trying to solve problems for yourself, or
improving the way you ask questions.
next prev parent reply other threads:[~2011-12-13 5:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 4:08 [PATCH 1/3] sound/soc/codecs: add LAPIS Semiconductor ML26124 Tomoya MORINAGA
2011-11-21 4:08 ` [PATCH 2/3] sound/soc/lapis: add machine driver Tomoya MORINAGA
2011-11-21 11:34 ` Mark Brown
2011-12-02 5:33 ` Tomoya MORINAGA
2011-12-02 6:14 ` Takashi Iwai
2011-12-02 6:18 ` Tomoya MORINAGA
2011-12-02 6:39 ` Takashi Iwai
2011-12-02 6:52 ` Tomoya MORINAGA
2011-12-02 7:01 ` Takashi Iwai
2011-12-02 7:13 ` Tomoya MORINAGA
2011-12-02 7:16 ` Takashi Iwai
2011-12-02 11:46 ` Mark Brown
2011-12-02 12:09 ` Tomoya MORINAGA
2011-12-02 12:22 ` Mark Brown
2011-12-02 12:35 ` Tomoya MORINAGA
2011-12-02 12:49 ` Mark Brown
2011-11-21 4:08 ` [PATCH 3/3] sound/soc/lapis: add platform driver Tomoya MORINAGA
2011-11-21 11:45 ` Mark Brown
2011-12-12 8:28 ` Tomoya MORINAGA
2011-12-12 10:05 ` [alsa-devel] " Mark Brown
2011-12-13 4:38 ` Tomoya MORINAGA
2011-12-13 4:59 ` Mark Brown [this message]
2011-11-21 11:26 ` [PATCH 1/3] sound/soc/codecs: add LAPIS Semiconductor ML26124 Mark Brown
2011-11-22 10:47 ` Tomoya MORINAGA
2011-11-22 11:19 ` Mark Brown
2011-11-25 2:03 ` Tomoya MORINAGA
2011-11-25 11:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213045958.GC4565@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=qi.wang@intel.com \
--cc=tiwai@suse.de \
--cc=tomoya.rohm@gmail.com \
--cc=vapier@gentoo.org \
--cc=yong.y.wang@intel.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox