* [PATCH] resource cgroups: remove bogus cast
@ 2011-12-05 21:13 Davidlohr Bueso
2011-12-07 12:15 ` Davidlohr Bueso
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2011-12-05 21:13 UTC (permalink / raw)
To: Pavel Emelianov, Tejun Heo, Li Zefan; +Cc: lkml, containers, cgroups
From: Davidlohr Bueso <dave@gnu.org>
The memparse() function already accepts const char * as the parsing string.
Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
kernel/res_counter.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/kernel/res_counter.c b/kernel/res_counter.c
index 34683ef..6d269cc 100644
--- a/kernel/res_counter.c
+++ b/kernel/res_counter.c
@@ -159,8 +159,7 @@ int res_counter_memparse_write_strategy(const char *buf,
return 0;
}
- /* FIXME - make memparse() take const char* args */
- *res = memparse((char *)buf, &end);
+ *res = memparse(buf, &end);
if (*end != '\0')
return -EINVAL;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] resource cgroups: remove bogus cast
2011-12-05 21:13 [PATCH] resource cgroups: remove bogus cast Davidlohr Bueso
@ 2011-12-07 12:15 ` Davidlohr Bueso
2011-12-07 13:38 ` Pavel Emelyanov
2011-12-13 15:44 ` Tejun Heo
2 siblings, 0 replies; 4+ messages in thread
From: Davidlohr Bueso @ 2011-12-07 12:15 UTC (permalink / raw)
To: Pavel Emelianov; +Cc: Tejun Heo, Li Zefan, lkml, containers, cgroups
ping?
On Mon, 2011-12-05 at 22:13 +0100, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> The memparse() function already accepts const char * as the parsing string.
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> ---
> kernel/res_counter.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/res_counter.c b/kernel/res_counter.c
> index 34683ef..6d269cc 100644
> --- a/kernel/res_counter.c
> +++ b/kernel/res_counter.c
> @@ -159,8 +159,7 @@ int res_counter_memparse_write_strategy(const char *buf,
> return 0;
> }
>
> - /* FIXME - make memparse() take const char* args */
> - *res = memparse((char *)buf, &end);
> + *res = memparse(buf, &end);
> if (*end != '\0')
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] resource cgroups: remove bogus cast
2011-12-05 21:13 [PATCH] resource cgroups: remove bogus cast Davidlohr Bueso
2011-12-07 12:15 ` Davidlohr Bueso
@ 2011-12-07 13:38 ` Pavel Emelyanov
2011-12-13 15:44 ` Tejun Heo
2 siblings, 0 replies; 4+ messages in thread
From: Pavel Emelyanov @ 2011-12-07 13:38 UTC (permalink / raw)
To: dave@gnu.org
Cc: Tejun Heo, Li Zefan, lkml, containers@lists.linux-foundation.org,
cgroups@vger.kernel.org
On 12/06/2011 01:13 AM, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> The memparse() function already accepts const char * as the parsing string.
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Acked-by: Pavel Emelyanov <xemul@parallels.com>
> ---
> kernel/res_counter.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/res_counter.c b/kernel/res_counter.c
> index 34683ef..6d269cc 100644
> --- a/kernel/res_counter.c
> +++ b/kernel/res_counter.c
> @@ -159,8 +159,7 @@ int res_counter_memparse_write_strategy(const char *buf,
> return 0;
> }
>
> - /* FIXME - make memparse() take const char* args */
> - *res = memparse((char *)buf, &end);
> + *res = memparse(buf, &end);
> if (*end != '\0')
> return -EINVAL;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] resource cgroups: remove bogus cast
2011-12-05 21:13 [PATCH] resource cgroups: remove bogus cast Davidlohr Bueso
2011-12-07 12:15 ` Davidlohr Bueso
2011-12-07 13:38 ` Pavel Emelyanov
@ 2011-12-13 15:44 ` Tejun Heo
2 siblings, 0 replies; 4+ messages in thread
From: Tejun Heo @ 2011-12-13 15:44 UTC (permalink / raw)
To: Davidlohr Bueso; +Cc: Pavel Emelianov, Li Zefan, lkml, containers, cgroups
On Mon, Dec 05, 2011 at 10:13:41PM +0100, Davidlohr Bueso wrote:
> From: Davidlohr Bueso <dave@gnu.org>
>
> The memparse() function already accepts const char * as the parsing string.
>
> Signed-off-by: Davidlohr Bueso <dave@gnu.org>
Applied to cgroup/for-3.3 w/ Pavel's Acked-by. Li Zefan, I committed
w/o your ack as the patch is trivial. Please scream if you aren't
happy.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-13 15:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-05 21:13 [PATCH] resource cgroups: remove bogus cast Davidlohr Bueso
2011-12-07 12:15 ` Davidlohr Bueso
2011-12-07 13:38 ` Pavel Emelyanov
2011-12-13 15:44 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox