From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755365Ab1LMSAU (ORCPT ); Tue, 13 Dec 2011 13:00:20 -0500 Received: from out3.smtp.messagingengine.com ([66.111.4.27]:36396 "EHLO out3.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754792Ab1LMSAR (ORCPT ); Tue, 13 Dec 2011 13:00:17 -0500 X-Sasl-enc: krm1tIgBHn/6h067Fjyn/PspyCWJOatslJFkPgxFLYZ+ 1323799216 Date: Tue, 13 Dec 2011 10:00:10 -0800 From: Greg KH To: Alexander Stein Cc: Joachim Foerster , Paul Gortmaker , Grant Likely , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: ISP1760: Add flags for interrupt polarity and edge/level trigger Message-ID: <20111213180010.GA29980@kroah.com> References: <1323768793-20633-1-git-send-email-alexander.stein@systec-electronic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1323768793-20633-1-git-send-email-alexander.stein@systec-electronic.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 13, 2011 at 10:33:13AM +0100, Alexander Stein wrote: > Signed-off-by: Alexander Stein > --- > drivers/usb/host/isp1760-if.c | 4 ++++ > include/linux/usb/isp1760.h | 2 ++ > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/drivers/usb/host/isp1760-if.c b/drivers/usb/host/isp1760-if.c > index a7dc1e1..0ef9867 100644 > --- a/drivers/usb/host/isp1760-if.c > +++ b/drivers/usb/host/isp1760-if.c > @@ -388,6 +388,10 @@ static int __devinit isp1760_plat_probe(struct platform_device *pdev) > devflags |= ISP1760_FLAG_DACK_POL_HIGH; > if (priv->dreq_polarity_high) > devflags |= ISP1760_FLAG_DREQ_POL_HIGH; > + if (priv->interrupt_polarity_high) > + devflags |= ISP1760_FLAG_INTR_POL_HIGH; > + if (priv->interrupt_edge_triggered) > + devflags |= ISP1760_FLAG_INTR_EDGE_TRIG; > } > > hcd = isp1760_register(mem_res->start, mem_size, irq_res->start, > diff --git a/include/linux/usb/isp1760.h b/include/linux/usb/isp1760.h > index de7de53..c5edbc8 100644 > --- a/include/linux/usb/isp1760.h > +++ b/include/linux/usb/isp1760.h > @@ -13,6 +13,8 @@ struct isp1760_platform_data { > unsigned analog_oc:1; /* Analog overcurrent */ > unsigned dack_polarity_high:1; /* DACK active high */ > unsigned dreq_polarity_high:1; /* DREQ active high */ > + unsigned interrupt_polarity_high:1; > + unsigned interrupt_edge_triggered:1; So you added these, and you check them, but who sets them? What is the point of this patch at this point in time? confused, greg k-h