linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Seiji Aguchi <seiji.aguchi@hds.com>
Cc: Vaibhav Nagarnaik <vnagarnaik@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Steven Rostedt <rostedt@goodmis.org>,
	Michael Rubin <mrubin@google.com>,
	David Sharp <dhsharp@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	Satoru Moriya <satoru.moriya@hds.com>
Subject: Re: [PATCH 2/2] trace,x86: Add x86 irq vector entry/exit tracepoints
Date: Tue, 13 Dec 2011 20:26:02 +0100	[thread overview]
Message-ID: <20111213192556.GD2421@somewhere.redhat.com> (raw)
In-Reply-To: <5C4C569E8A4B9B42A84A977CF070A35B2C57EE47BC@USINDEVS01.corp.hds.com>

On Mon, Dec 12, 2011 at 04:52:18PM -0500, Seiji Aguchi wrote:
> Hi,
> 
> I'm interested in these tracepoints.
> But this patch removed from -mm tree for some reason.
> 
> http://www.spinics.net/lists/mm-commits/msg85707.html
> 
> Do you plan to update it and push to upstream?

Oh weird. Doesn't seem to be in -tip either. Anybody has
any clue about where this patch went?

> 
> >@@ -859,7 +860,9 @@ void __irq_entry smp_apic_timer_interrupt(struct pt_regs *regs)
> > 	 */
> > 	exit_idle();
> > 	irq_enter();
> >+	trace_irq_vector_entry(LOCAL_TIMER_VECTOR);
> > 	local_apic_timer_interrupt();
> >+	trace_irq_vector_exit(LOCAL_TIMER_VECTOR);
> > 	irq_exit();
> 
> It would be better if you add "regs" to the argument of trace_irq_vector_entry()/ trace_irq_vector_exit().
> 
> With "regs", we are able to know what part of the system CPUs execute periodically. 
> This information really helps us find a root cause of system slowdown or hung up.

What about using perf for that?

Just run:

	perf record -ag
	^C
	perf report

And you should find in the callchains some informations about where your CPUs
are spending time.

If you system is too slow for that but you're doing background tracing with
ftrace, you can use stacktrace with ftrace.

If it's hung up then we have the watchdog lockup detector.

  reply	other threads:[~2011-12-13 19:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29 23:59 [PATCH 0/2] Add tracepoints to trace all x86 system IRQs Vaibhav Nagarnaik
2011-07-29 23:59 ` [PATCH 1/2] trace,x86: Add tracepoint to x86 timer interrupt handler Vaibhav Nagarnaik
2011-09-21  9:01   ` Thomas Gleixner
2011-09-21 18:20     ` Vaibhav Nagarnaik
2011-07-29 23:59 ` [PATCH 2/2] trace,x86: Add x86 irq vector entry/exit tracepoints Vaibhav Nagarnaik
2011-12-12 21:52   ` Seiji Aguchi
2011-12-13 19:26     ` Frederic Weisbecker [this message]
2011-12-14  8:18       ` Ingo Molnar
2011-12-14 14:47         ` Frederic Weisbecker
2011-12-14 16:19           ` Vaibhav Nagarnaik
2011-12-14 15:09       ` Seiji Aguchi
2011-12-14 16:34         ` Frederic Weisbecker
2011-12-14 16:37           ` Steven Rostedt
2011-12-14 17:46           ` Seiji Aguchi
2011-12-14 18:09             ` Steven Rostedt
2011-12-15  2:23               ` Seiji Aguchi
2012-02-03 15:40           ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111213192556.GD2421@somewhere.redhat.com \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dhsharp@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mrubin@google.com \
    --cc=rostedt@goodmis.org \
    --cc=satoru.moriya@hds.com \
    --cc=seiji.aguchi@hds.com \
    --cc=tglx@linutronix.de \
    --cc=vnagarnaik@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).