Re: [PATCH] omap: rx51: initialize isp1704 properly

Tony Lindgren
2011-12-13T21:55:08Z

* Felipe Contreras <felipe.contreras@gmail.com> [111213 11:33]:
> On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Felipe Contreras <felipe.contreras@gmail.com> [111208 11:52]:
> >> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus <krohei@gmail.com> wrote:
> >> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote:
> >> >> From: Heikki Krogerus <krohei@gmail.com>
> >> >
> >> > I would prefer that you change this so this is from you, like it
> >> > actually is. You can mention me in the commit message if you like.
> >>
> >> Well, you came with the fix, I just typed it down, but as you wish :)
> >>
> >> >> Without this USB networking doesn't work as the link is never detected.
> >> >
> >> > What this changes is, it leaves the transceiver powered by default
> >> > instead of setting it into power off mode. So not only USB networking
> >> > is affected by this. If isp1704_charger is not enabled with RX51, USB
> >> > does not work at all. Please change the comment.
> >>
> >> I've updated the patch.
> >
> > Sorry what's the deal with this one? Is this the one to use or is there
> > some other patch?
>
> Yeap, there's v2 of this one:
> 1323375780-13190-1-git-send-email-felipe.contreras@nokia.com

OK, thanks applying into fixes.

Tony