From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755931Ab1LMVzI (ORCPT ); Tue, 13 Dec 2011 16:55:08 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:29099 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754742Ab1LMVzF (ORCPT ); Tue, 13 Dec 2011 16:55:05 -0500 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 98.234.237.12 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+fmdcb/DBx4dCpxTZ9zbJT Date: Tue, 13 Dec 2011 13:55:01 -0800 From: Tony Lindgren To: Felipe Contreras Cc: Heikki Krogerus , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Kalle Jokiniemi , Anton Vorontsov Subject: Re: [PATCH] omap: rx51: initialize isp1704 properly Message-ID: <20111213215501.GU32251@atomide.com> References: <20111207193141.GG31337@atomide.com> <1323287816-2809-1-git-send-email-felipe.contreras@gmail.com> <20111208144044.GA25415@xps8300> <20111212194445.GG32251@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Felipe Contreras [111213 11:33]: > On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren wrote: > > * Felipe Contreras [111208 11:52]: > >> On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus wrote: > >> > On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: > >> >> From: Heikki Krogerus > >> > > >> > I would prefer that you change this so this is from you, like it > >> > actually is. You can mention me in the commit message if you like. > >> > >> Well, you came with the fix, I just typed it down, but as you wish :) > >> > >> >> Without this USB networking doesn't work as the link is never detected. > >> > > >> > What this changes is, it leaves the transceiver powered by default > >> > instead of setting it into power off mode. So not only USB networking > >> > is affected by this. If isp1704_charger is not enabled with RX51, USB > >> > does not work at all. Please change the comment. > >> > >> I've updated the patch. > > > > Sorry what's the deal with this one? Is this the one to use or is there > > some other patch? > > Yeap, there's v2 of this one: > 1323375780-13190-1-git-send-email-felipe.contreras@nokia.com OK, thanks applying into fixes. Tony