Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files v2

[Andi Kleen <ak@linux.intel.com>]

On Wed, Dec 14, 2011 at 12:03:03AM +0100, Thomas Gleixner wrote:
> On Tue, 13 Dec 2011, Andi Kleen wrote:
> 
> > > Hi Andi, is it possible to do say kstrdup or something instead of
> > 
> > It's possible, just would add complexity with an additional
> > error path.
> > 
> > > variable-size array in fn[strlen(name) + 1] ? As far as I remember
> > > we already had some warnings with them at least in perf land (or
> > > trace land). Or I miss something?
> > 
> > Not aware of any problems with tracing or perf. I like them at least.
> 
> That does not make them better. We had wreckage before and you can
> just consult commit a84a79e4d3 and then find a good explanation why
> your usage is safe.

Ok. I must admit I sometimes forget with what substandard toolchains
some of the ports are afflicted with.

But fair enough. I'll just make the code longer, more complex,
more error prone and slower.

Should probably find some way to let gcc warn about them, I'm sure
I'm not the only one who likes them.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only