From: Thierry Reding <thierry.reding@avionic-design.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>, Ryan Mallon <rmallon@gmail.com>,
Bill Gatliff <bgat@billgatliff.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
viresh kumar <viresh.kumar@st.com>,
Shawn Guo <shawn.guo@linaro.org>,
Ryan Mallon <ryan@bluewatersys.com>
Subject: Re: [PATCH 1/3] PWM: add pwm framework support
Date: Wed, 14 Dec 2011 11:03:38 +0100 [thread overview]
Message-ID: <20111214100338.GA18348@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <20111207090734.GN27267@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
* Sascha Hauer wrote:
> I have a branch which adds a basic PWM framework. It doesn't change the
> pwm API at all, but only adds support for registering multiple PWM
> drivers. All in Kernel drivers are converted to this new framework, but
> except the i.MX driver all of them are untested. I'm quite confident
> that the drivers itself work, but there will probably be some Kconfig
> related issues which I wasn't able to sort out. The corresponding
> Maintainers should probably have a look over it. Feel free to post
> the patches if you are prepared to work on the comments you receive.
> Otherwise I'll see if I find some time maybe next week.
[...]
I've looked at this in more detail and one thing that irritates me is that
the current driver API requires a driver to register a pwm_chip structure for
each PWM it can control. Wouldn't it be easier in such cases to just specify
how many PWMs a chip wants to register, much like gpiolib does it?
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-12-14 10:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 10:41 [PATCH v3] implement a generic PWM framework Sascha Hauer
2011-06-30 10:41 ` [PATCH 1/3] PWM: add pwm framework support Sascha Hauer
2011-06-30 11:07 ` Bill Gatliff
2011-06-30 12:41 ` Arnd Bergmann
2011-06-30 16:17 ` Bill Gatliff
2011-06-30 17:02 ` Sascha Hauer
2011-06-30 19:45 ` Bill Gatliff
2011-06-30 23:24 ` Ryan Mallon
2011-07-01 0:33 ` H Hartley Sweeten
2011-07-01 0:55 ` Mike Frysinger
2011-07-01 7:37 ` Sascha Hauer
2011-07-01 8:28 ` Ryan Mallon
2011-07-01 8:54 ` Sascha Hauer
2011-07-02 0:40 ` Ryan Mallon
2011-07-04 7:55 ` Sascha Hauer
2011-07-04 10:43 ` Ryan Mallon
2011-07-04 11:05 ` Kurt Van Dijck
2011-07-04 13:53 ` Arnd Bergmann
2011-07-04 14:19 ` Kurt Van Dijck
2011-07-04 12:43 ` Sascha Hauer
2011-07-04 14:07 ` Arnd Bergmann
2011-12-07 8:53 ` Thierry Reding
2011-12-07 9:07 ` Sascha Hauer
2011-12-14 10:03 ` Thierry Reding [this message]
2011-12-14 11:37 ` Sascha Hauer
2011-07-01 9:49 ` Dmitry Eremin-Solenikov
2011-06-30 10:41 ` [PATCH 2/3] ARM mxs: adjust pwm resources to what the driver expects Sascha Hauer
2011-06-30 11:30 ` Arnd Bergmann
2011-06-30 10:41 ` [PATCH 3/3] pwm: Add a i.MX23/28 pwm driver Sascha Hauer
2011-06-30 11:42 ` Arnd Bergmann
2011-06-30 15:11 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214100338.GA18348@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=arnd@arndb.de \
--cc=bgat@billgatliff.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmallon@gmail.com \
--cc=ryan@bluewatersys.com \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=viresh.kumar@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox