From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shreshtha Kumar SAHU <shreshthakumar.sahu@stericsson.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Denis Kuzmenko <linux@solonet.org.ua>,
Linus Walleij <linus.walleij@linaro.org>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
Richard Purdie <rpurdie@rpsys.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] leds: driver for ab5500 high voltage leds
Date: Wed, 14 Dec 2011 19:37:15 +0800 [thread overview]
Message-ID: <20111214113714.GJ3072@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <2E48302EED53D048A7BA72B0A307FB511CF4DFD1C0@EXDCVYMBSTM005.EQ1STM.local>
On Wed, Dec 14, 2011 at 11:23:58AM +0100, Shreshtha Kumar SAHU wrote:
> The actual amount of current flowing hence brightness variation can then be
> altered using PWM, which is also the case in present driver.
> Hence the idea of current control sysfs interface is provided to further
> decrease the max current through the LED(s) if required for saving power
> (but can never exceed the max current set by the platform).
> After fixing the current, "brightness" interface can be used to control
> brightness which internally cofigures the PWM register.
The above basically sounds like you're using the current limit as a way
of adjusting the maximum brightness dynamically for power saving
reasons. This doesn't sound like something that individual drivers
should be doing, it sounds like something that either the subsystem or
userspace code ought to be implementing. It'd seem more natural for the
driver to scale both the PWM and current settings with brightness.
next prev parent reply other threads:[~2011-12-14 11:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 13:56 [PATCH] leds: driver for ab5500 high voltage leds Linus Walleij
2011-12-03 21:49 ` Mark Brown
2011-12-07 14:16 ` Linus Walleij
2011-12-07 15:47 ` Mark Brown
2011-12-03 22:49 ` Denis Kuzmenko
2011-12-07 14:07 ` Linus Walleij
2011-12-07 18:01 ` Denis Kuzmenko
2011-12-08 0:00 ` Andrew Morton
2011-12-08 1:19 ` Mark Brown
2011-12-14 10:23 ` Shreshtha Kumar SAHU
2011-12-14 11:37 ` Mark Brown [this message]
2011-12-14 14:01 ` Shreshtha Kumar SAHU
2011-12-14 14:47 ` Mark Brown
2011-12-14 18:34 ` Linus Walleij
2011-12-15 7:11 ` Mark Brown
2011-12-16 5:10 ` Shreshtha Kumar SAHU
2011-12-22 17:43 ` Mark Brown
2011-12-19 11:26 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214113714.GJ3072@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@solonet.org.ua \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
--cc=shreshthakumar.sahu@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).