From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Warren <swarren@nvidia.com>
Cc: Haojian Zhuang <haojian.zhuang@marvell.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"eric.y.miao@gmail.com" <eric.y.miao@gmail.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>
Subject: Re: [PATCH V2 1/2] pinctrl: enable pinmux for pxa series
Date: Wed, 14 Dec 2011 15:40:49 +0000 [thread overview]
Message-ID: <201112141540.49243.arnd@arndb.de> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF1751860B1F@HQMAIL01.nvidia.com>
On Tuesday 13 December 2011, Stephen Warren wrote:
> Haojian Zhuang wrote at Tuesday, December 13, 2011 2:41 AM:
>
> > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
>
> > +obj-$(CONFIG_PINMUX_PXA168) += pinmux-pxa168.o pinctrl-pxa3xx.o
> > +obj-$(CONFIG_PINMUX_PXA300) += pinmux-pxa300.o pinctrl-pxa3xx.o
> > +obj-$(CONFIG_PINMUX_PXA910) += pinmux-pxa910.o pinctrl-pxa3xx.o
>
> That structure will cause problems if multiple of those Kconfig options
> are enabled at once, as in a multi-SoC kernel. Instead, shouldn't this be:
>
> obj-$(CONFIG_PINCTRL_PXA3XX) += pinctrl-pxa3xx.o
> obj-$(CONFIG_PINMUX_PXA168) += pinmux-pxa168.o
> obj-$(CONFIG_PINMUX_PXA300) += pinmux-pxa300.o
> obj-$(CONFIG_PINMUX_PXA910) += pinmux-pxa910.o
I'm pretty sure the first version is ok too, as long as none of the
options can be built as modules. Your version seems to be more common though.
Arnd
next prev parent reply other threads:[~2011-12-14 15:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 9:40 [PATCH V2 0/2] pinctrl: support PXA series Haojian Zhuang
2011-12-13 9:40 ` [PATCH V2 1/2] pinctrl: enable pinmux for pxa series Haojian Zhuang
2011-12-13 16:19 ` Arnd Bergmann
2011-12-13 22:49 ` Linus Walleij
2011-12-15 2:03 ` Haojian Zhuang
2011-12-13 18:28 ` Stephen Warren
2011-12-14 15:40 ` Arnd Bergmann [this message]
2011-12-15 2:10 ` Haojian Zhuang
2011-12-15 5:45 ` Haojian Zhuang
2011-12-13 9:40 ` [PATCH V2 2/2] ARM: mmp: enable pinmux in platform driver Haojian Zhuang
2011-12-13 23:02 ` Linus Walleij
2011-12-13 23:07 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112141540.49243.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox