Re: [PATCH-WIP] convert CPU sysdev class to a real subsytem (needed for CPU modaliases)

[Greg KH <greg@kroah.com>]

On Wed, Dec 14, 2011 at 03:11:34AM +0100, Kay Sievers wrote:
> On Wed, Dec 14, 2011 at 02:21, Greg KH <greg@kroah.com> wrote:
> > On Wed, Dec 14, 2011 at 01:50:57AM +0100, Kay Sievers wrote:
> >> On Fri, Dec 9, 2011 at 23:34, Greg KH <greg@kroah.com> wrote:
> >> > On Fri, Dec 09, 2011 at 04:25:21PM +0100, Kay Sievers wrote:
> >> >> Greg, would be nice, if you can take a quick look a the driver core (not
> >> >> the sysdev) bits in core.c, bus.c, device.h, ... and its interaction, if
> >> >> they look sane to you. I'll then split the driver core stuff out, so we
> >> >> can merge that before we port the individual drivers over.
> >> >
> >> > Yes, it looks sane to me, thanks again for doing this work.
> >>
> >> Split-up patches are here:
> >>   http://git.kernel.org/?p=linux/kernel/git/kay/patches.git;a=tree
> >>
> >> That's the size of it:
> >>   60 files changed, 1170 insertions(+), 1421 deletions(-)
> >
> > Very nice.
> >
> >> The current state and the list of the remaining non-x86 files is here:
> >>   http://git.kernel.org/?p=linux/kernel/git/kay/patches.git;a=blob;f=README;hb=HEAD
> >>
> >> We need a plan now. :)
> >
> > If I take those patches, none of those other ones will break their
> > build, right?
> 
> The first patch should not break anything, the non-core things
> shouldn't too.

Nice, I've applied the first patch to my tree and pushed it out and I'll
read over the rest now.

> > Or will the cpu ones?
> 
> The cpu patch as it is will break power, s390, sh and tile.
>   $ git grep -w -l cpu_sysdev_class
>   arch/powerpc/kernel/sysfs.c
>   arch/powerpc/platforms/pseries/pseries_energy.c
>   arch/s390/kernel/smp.c
>   arch/sh/kernel/cpu/sh4/sq.c
>   arch/tile/kernel/sysfs.c
> 
> If all should be bisectable, we would need to merge these changes into
> the cpu patch.

Yeah, we need to do that, I'll look at it.

> The other two core patches, node and memory, could need arch fixes
> too, but a quick grep did not reveal anything.

Ok, we might be safe there, I'll look at them.

thanks,

greg k-h