From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752991Ab1LOHKt (ORCPT ); Thu, 15 Dec 2011 02:10:49 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:38801 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318Ab1LOHKr (ORCPT ); Thu, 15 Dec 2011 02:10:47 -0500 Date: Thu, 15 Dec 2011 08:08:57 +0100 From: Ingo Molnar To: Kees Cook Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , "Paul E. McKenney" , Al Viro Subject: Re: [PATCH] sched: mark parent and real_parent as __rcu Message-ID: <20111215070857.GD14237@elte.hu> References: <20111214223925.GA27578@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111214223925.GA27578@www.outflux.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=AWL,BAYES_00 autolearn=no SpamAssassin version=3.3.1 -2.0 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 AWL AWL: From: address is in the auto white-list Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kees Cook wrote: > The parent and real_parent pointers should be considered __rcu, since > they should be held under either tasklist_lock or rcu_read_lock. > > Signed-off-by: Kees Cook > --- > include/linux/sched.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Did you get some warning that alerted you to this problem? If yes then please include it in the changelog, so that people hitting the message can easily find it. Same consideration applies the second patch as well. Thanks, Ingo