From: Arnd Bergmann <arnd@arndb.de>
To: myungjoo.ham@samsung.com
Cc: "Samuel Ortiz" <sameo@linux.intel.com>,
김동근 <dg77.kim@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"gregkh@suse.de" <gregkh@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
박경민 <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC
Date: Thu, 15 Dec 2011 15:34:01 +0000 [thread overview]
Message-ID: <201112151534.01995.arnd@arndb.de> (raw)
In-Reply-To: <33434703.581501323909131767.JavaMail.weblogic@epml15>
On Thursday 15 December 2011, MyungJoo Ham wrote:
> Arnd Bergmann wrote:
> > On Monday 12 December 2011, Samuel Ortiz wrote:
> > The part that is not clear to me is how this new driver fits in
> > with the first fsa9480 driver and the currently discussed extcon
> > subsystem, apparently all written by the same team at Samsung.
> > Is this misc driver still useful when the extcon framework gets
> > merged?
>
> When extcom gets merged, this driver should be updated. It looks like allowing
> the interrupt handler to update extcon state would be enough. Bascially, this
> is all this driver is required for extcon to work. (and the prvious author of
> extcon--"extended" switch class at that time--was the author of this patch.)
>
> Anyway, this patch has just told me that I'll need to add more sysfs entries
> for extcon to show the list of cable names and/or to show the status for each
> of them, soon or later.
I think it would be better not to merge this driver until the user interface
in the extcon framework has been finalized. I don't mind the driver, but I
want to prevent user interfaces from appearing in the kernel that we
intend to change anyway.
How about dropping the driver from the mfd tree, and adding it into the
extcon series for the next posting?
Arnd
next prev parent reply other threads:[~2011-12-15 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 0:32 Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC MyungJoo Ham
2011-12-15 15:34 ` Arnd Bergmann [this message]
2011-12-15 17:25 ` Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2011-12-16 5:13 함명주
2011-12-16 13:58 ` Arnd Bergmann
2011-11-24 9:12 [PATCH 1/2] MFD: MAX8997: add platform data for MAX8997 MUIC driver Donggeun Kim
2011-11-24 9:12 ` [PATCH 2/2] misc: add driver support for MAX8997 MUIC Donggeun Kim
2011-11-28 23:48 ` Andrew Morton
2011-11-29 0:02 ` Kyungmin Park
2011-11-29 9:59 ` Samuel Ortiz
2011-12-12 17:08 ` Samuel Ortiz
2011-12-14 16:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112151534.01995.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dg77.kim@samsung.com \
--cc=gregkh@suse.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox