From: Joerg Roedel <joerg.roedel@amd.com>
To: Hiroshi DOYU <hdoyu@nvidia.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Tony Lindgren <tony@atomide.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] [RFC] ARM: IOMMU: Tegra20: iommu_ops for GART driver
Date: Fri, 16 Dec 2011 16:43:31 +0100 [thread overview]
Message-ID: <20111216154331.GD29877@amd.com> (raw)
In-Reply-To: <1323954690-7000-2-git-send-email-hdoyu@nvidia.com>
On Thu, Dec 15, 2011 at 03:11:29PM +0200, Hiroshi DOYU wrote:
> Tegra 20 IOMMU H/W, GART (Graphics Address Relocation Table). This
> patch implements struct iommu_ops for GART for the upper IOMMU API.
>
> This H/W module supports only single virtual address space(domain),
> and manages a single level 1-to-1 mapping H/W translation page table.
>
> Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>
> ---
> drivers/iommu/Kconfig | 11 +
> drivers/iommu/Makefile | 1 +
> drivers/iommu/tegra-gart.c | 451 ++++++++++++++++++++++++++++++++++++++++++++
The code looks good in general. I think we need to extend the IOMMU-API
a little bit to better support GART IOMMUs. A user of the IOMMU-API
should be able to get the information about the iova-base and size of
the aperture for example. These extensions will be beneficial for
porting other GART-like driver to the IOMMU-API too.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-12-16 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1323954690-7000-1-git-send-email-hdoyu@nvidia.com>
2011-12-15 13:11 ` [PATCH v2 1/2] [RFC] ARM: IOMMU: Tegra20: iommu_ops for GART driver Hiroshi DOYU
2011-12-16 15:43 ` Joerg Roedel [this message]
2011-12-17 1:15 ` Hiroshi Doyu
2011-12-19 6:27 ` Hiroshi Doyu
2011-12-15 13:11 ` [PATCH v2 2/2] [RFC] ARM: IOMMU: Tegra30: iommu_ops for SMMU driver Hiroshi DOYU
2011-12-16 15:39 ` Joerg Roedel
2011-12-17 1:03 ` Hiroshi Doyu
2011-12-17 1:28 ` Hiroshi Doyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216154331.GD29877@amd.com \
--to=joerg.roedel@amd.com \
--cc=hdoyu@nvidia.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox