From: Marek Vasut <marek.vasut@gmail.com>
To: joe@perches.com
Cc: Andy Whitcroft <apw@shadowen.org>, linux-kernel@vger.kernel.org
Subject: checkpatch.pl misreporting bugs with array fillings
Date: Fri, 16 Dec 2011 22:59:28 +0100 [thread overview]
Message-ID: <201112162259.29043.marek.vasut@gmail.com> (raw)
Hi,
the following testcase is probably misreported by checkpatch.pl:
static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
{0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
{0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
};
The result is:
ERROR: space prohibited before open square bracket '['
#2: FILE: testcase.c:2:
+ {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
ERROR: space prohibited before open square bracket '['
#3: FILE: testcase.c:3:
+ {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
total: 2 errors, 0 warnings, 5 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
MULTISTATEMENT_MACRO_USE_DO_WHILE
testcase.c has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Cheers!
M
next reply other threads:[~2011-12-16 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 21:59 Marek Vasut [this message]
2011-12-16 22:24 ` checkpatch.pl misreporting bugs with array fillings Andy Whitcroft
2011-12-16 22:31 ` Marek Vasut
2011-12-19 10:13 ` Andy Whitcroft
2011-12-17 0:15 ` Joe Perches
2011-12-17 0:22 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112162259.29043.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=apw@shadowen.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox