From: Frederic Weisbecker <fweisbec@gmail.com>
To: Mandeep Singh Baines <msb@chromium.org>
Cc: Tejun Heo <tj@kernel.org>, Li Zefan <lizf@cn.fujitsu.com>,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <paul@paulmenage.org>
Subject: Re: [PATCH] cgroup: remove redundate get/put of old css_set from migrate
Date: Sat, 17 Dec 2011 17:41:48 +0100 [thread overview]
Message-ID: <20111217164145.GA437@somewhere> (raw)
In-Reply-To: <1324053511-24591-1-git-send-email-msb@chromium.org>
On Fri, Dec 16, 2011 at 08:38:31AM -0800, Mandeep Singh Baines wrote:
> We can now assume that the css_set reference held by the task
> will not go away for an exiting task. PF_EXITING state can be
> trusted throughout migration by checking it after locking
> threadgroup.
>
> This patch depends on:
>
> commit cd3d095275374220921fcf0d4e0c16584b26ddbc
> Author: Tejun Heo <tj@kernel.org>
> Date: Mon Dec 12 18:12:21 2011 -0800
>
> cgroup: always lock threadgroup during migration
>
> Signed-off-by: Mandeep Singh Baines <msb@chromium.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizf@cn.fujitsu.com>
> Cc: containers@lists.linux-foundation.org
> Cc: cgroups@vger.kernel.org
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Reviewed-by: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Paul Menage <paul@paulmenage.org>
> ---
> kernel/cgroup.c | 25 ++++++-------------------
> 1 files changed, 6 insertions(+), 19 deletions(-)
next prev parent reply other threads:[~2011-12-17 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 16:38 [PATCH] cgroup: remove redundate get/put of old css_set from migrate Mandeep Singh Baines
2011-12-17 16:41 ` Frederic Weisbecker [this message]
2011-12-19 2:01 ` Frederic Weisbecker
2011-12-19 17:16 ` Tejun Heo
2011-12-19 17:20 ` Tejun Heo
2011-12-19 18:44 ` [PATCH v2] " Mandeep Singh Baines
2011-12-20 18:45 ` Frederic Weisbecker
2011-12-20 19:01 ` [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration Frederic Weisbecker
2011-12-20 19:01 ` [PATCH 2/2] cgroup: Drop task_lock(parent) on cgroup_fork() Frederic Weisbecker
2011-12-20 19:14 ` [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration Tejun Heo
2011-12-20 19:27 ` Frederic Weisbecker
2011-12-20 21:29 ` Mandeep Singh Baines
2011-12-21 1:53 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111217164145.GA437@somewhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=msb@chromium.org \
--cc=oleg@redhat.com \
--cc=paul@paulmenage.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).