From: Andy Whitcroft <apw@canonical.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: joe@perches.com, linux-kernel@vger.kernel.org
Subject: Re: checkpatch.pl misreporting bugs with array fillings
Date: Mon, 19 Dec 2011 10:13:51 +0000 [thread overview]
Message-ID: <20111219101351.GE2830@shadowen.org> (raw)
In-Reply-To: <201112162331.06505.marek.vasut@gmail.com>
On Fri, Dec 16, 2011 at 11:31:06PM +0100, Marek Vasut wrote:
> > On Fri, Dec 16, 2011 at 9:59 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > > Hi,
> > >
> > > the following testcase is probably misreported by checkpatch.pl:
> > >
> > > static const unsigned char pci_irq_swizzle[2][PCI_MAX_DEVICES] = {
> > > {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> > > {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> > > };
> > >
> > > The result is:
> > >
> > > ERROR: space prohibited before open square bracket '['
> > > #2: FILE: testcase.c:2:
> > > + {0, 0, 0, 0, 0, 0, 0, 27, 27, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> > >
> > > ERROR: space prohibited before open square bracket '['
> > > #3: FILE: testcase.c:3:
> > > + {0, 0, 0, 0, 0, 0, 0, 29, 29, [9 ... PCI_MAX_DEVICES - 1] = 0 },
> > >
> > > total: 2 errors, 0 warnings, 5 lines checked
> > >
> > > NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
> > > MULTISTATEMENT_MACRO_USE_DO_WHILE
> > >
> > > testcase.c has style problems, please review.
> >
> > Hmmm will have a look...
>
> Thanks! I'd send a patch, but I'm now doing checkpatch cleanup of uboot sources
> so I'm just submitting a testcase and delegating the issue.
Ok, this one may well be simple to fix. Does the version of checkpatch
below work ok for you:
http://people.canonical.com/~apw/checkpatch/checkpatch-next.pl
-apw
next prev parent reply other threads:[~2011-12-19 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 21:59 checkpatch.pl misreporting bugs with array fillings Marek Vasut
2011-12-16 22:24 ` Andy Whitcroft
2011-12-16 22:31 ` Marek Vasut
2011-12-19 10:13 ` Andy Whitcroft [this message]
2011-12-17 0:15 ` Joe Perches
2011-12-17 0:22 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111219101351.GE2830@shadowen.org \
--to=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox