From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752848Ab1LSPE5 (ORCPT ); Mon, 19 Dec 2011 10:04:57 -0500 Received: from zene.cmpxchg.org ([85.214.230.12]:46979 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880Ab1LSPEy (ORCPT ); Mon, 19 Dec 2011 10:04:54 -0500 Date: Mon, 19 Dec 2011 16:04:41 +0100 From: Johannes Weiner To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Michal Hocko , "akpm@linux-foundation.org" , Hugh Dickins , Ying Han Subject: Re: [PATCH 1/4] memcg: simplify page cache charging. Message-ID: <20111219150441.GA1415@cmpxchg.org> References: <20111214164734.4d7d6d97.kamezawa.hiroyu@jp.fujitsu.com> <20111214164922.05fb4afe.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111214164922.05fb4afe.kamezawa.hiroyu@jp.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2011 at 04:49:22PM +0900, KAMEZAWA Hiroyuki wrote: > From: KAMEZAWA Hiroyuki > > This patch is a clean up. No functional/logical changes. > > Because of commit ef6a3c6311, FUSE uses replace_page_cache() instead > of add_to_page_cache(). Then, mem_cgroup_cache_charge() is not > called against FUSE's pages from splice. > > So, Now, mem_cgroup_cache_charge() doesn't receive a page on LRU > unless it's not SwapCache. > For checking, WARN_ON_ONCE(PageLRU(page)) is added. > > Signed-off-by: KAMEZAWA Hiroyuki I like this. Acked-by: Johannes Weiner