From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753681Ab1LTAvG (ORCPT ); Mon, 19 Dec 2011 19:51:06 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:59397 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824Ab1LTAvE (ORCPT ); Mon, 19 Dec 2011 19:51:04 -0500 Date: Tue, 20 Dec 2011 00:51:01 +0000 From: Mark Brown To: Shawn Guo Cc: Liam Girdwood , Dong Aisheng , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/5] ASoC: mxs: correct 'direction' of device_prep_dma_cyclic Message-ID: <20111220005100.GJ2860@opensource.wolfsonmicro.com> References: <1323791286-29574-1-git-send-email-shawn.guo@linaro.org> <1323848866-19768-1-git-send-email-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1323848866-19768-1-git-send-email-shawn.guo@linaro.org> X-Cookie: You'll be sorry... User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2011 at 03:47:46PM +0800, Shawn Guo wrote: > The commit 49920bc (dmaengine: add new enum dma_transfer_direction) > changes the type of parameter 'direction' of device_prep_dma_cyclic > from dma_data_direction to dma_transfer_direction. Applied, thanks. With patches like this you really need to supply more context - knowing which release the commit you're talking about appears in is useful for exammple, as is having some hint as to what the rest of the series is (does this patch depend on any of the earlier patches, and if not why is it part of a series).