From: NeilBrown <neilb@suse.de>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
rpurdie@rpsys.net, linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 1/2] leds-tca6507: allow driver to compile when GPIOLIB is not available.
Date: Tue, 20 Dec 2011 16:37:50 +1100 [thread overview]
Message-ID: <20111220163750.00e135c6@notabene.brown> (raw)
In-Reply-To: <4EEF9FCA.4040401@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
On Mon, 19 Dec 2011 12:34:18 -0800 Randy Dunlap <rdunlap@xenotime.net> wrote:
> On 12/18/2011 04:20 PM, NeilBrown wrote:
> > This driver can configure the outputs as GPIO line instead of LEDs. But
> > that only works if GPIOLIB is available. So make that code conditional
> > on the library's availability.
> >
> > Also remove the 'teardown' callback as it is never called and should
> > never be needed.
> >
> > Reported-by: Randy Dunlap <rdunlap@xenotime.net>,
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>,
> > Signed-off-by: NeilBrown <neilb@suse.de>
>
> Hi Neil,
>
> with linux-next 20111219 and this patch applied, I now get:
>
> drivers/leds/leds-tca6507.c: In function 'tca6507_remove':
> drivers/leds/leds-tca6507.c:677:9: error: 'struct tca6507_chip' has no member named 'gpio'
> drivers/leds/leds-tca6507.c:678:3: error: implicit declaration of function 'gpiochip_remove'
> drivers/leds/leds-tca6507.c:678:33: error: 'struct tca6507_chip' has no member named 'gpio'
>
> when GPIOLIB is not enabled.
Drat - I forgot the 'remove' code.
I cannot easily compile for an ARCH that doesn't include GPIOLIB, but it
seems that if I put
#undef CONFIG_GPIOLIB
at the top of leds-tca6507.c it comes close enough for testing.
So the next version should get that right. I'll repost.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2011-12-20 5:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 0:20 [PATCH 0/2] Two fixes for leds-tca6507 NeilBrown
2011-12-19 0:20 ` [PATCH 1/2] leds-tca6507: allow driver to compile when GPIOLIB is not available NeilBrown
2011-12-19 20:34 ` Randy Dunlap
2011-12-20 5:37 ` NeilBrown [this message]
2011-12-19 0:20 ` [PATCH 2/2] leds-tca6507 - fix off by one error NeilBrown
-- strict thread matches above, loose matches on Subject: below --
2011-12-20 5:44 [PATCH 0/2] Two fixes for leds-tca6507 - Version 2 NeilBrown
2011-12-20 5:44 ` [PATCH 1/2] leds-tca6507: allow driver to compile when GPIOLIB is not available NeilBrown
2011-12-20 20:16 ` Randy Dunlap
2011-12-20 20:26 ` Randy Dunlap
2011-12-20 21:03 ` NeilBrown
2011-12-20 22:23 ` Andrew Morton
2011-12-30 0:35 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220163750.00e135c6@notabene.brown \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=rpurdie@rpsys.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).