From: Frederic Weisbecker <fweisbec@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Containers <containers@lists.linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <paul@paulmenage.org>,
Mandeep Singh Baines <msb@chromium.org>
Subject: Re: [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration
Date: Tue, 20 Dec 2011 20:27:04 +0100 [thread overview]
Message-ID: <20111220192703.GB17668@somewhere> (raw)
In-Reply-To: <20111220191443.GE10752@google.com>
On Tue, Dec 20, 2011 at 11:14:43AM -0800, Tejun Heo wrote:
> Hello, Frederic.
>
> On Tue, Dec 20, 2011 at 08:01:12PM +0100, Frederic Weisbecker wrote:
> > When we fetch the css_set of the tasks on cgroup migration, we don't need
> > anymore to synchronize against cgroup_exit() that could swap the old one
> > with init_css_set. Now that we are using threadgroup_lock() during
> > the migrations, we don't need to worry about it anymore.
> >
> > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Li Zefan <lizf@cn.fujitsu.com>
> > Cc: Containers <containers@lists.linux-foundation.org>
> > Cc: Cgroups <cgroups@vger.kernel.org>
> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > Cc: Oleg Nesterov <oleg@redhat.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Paul Menage <paul@paulmenage.org>
> > Cc: Mandeep Singh Baines <msb@chromium.org>
>
> I like this but it doesn't apply on top of cgroup/for-3.3. It
> collides with Mandeep's patch. Can you please rebase?
Yeah it was made on top of last Mandeep's patch. Let me
rebase on top of your branch, will resend soon.
Thanks.
>
> Li, can you please ack?
>
> Thanks.
>
> --
> tejun
next prev parent reply other threads:[~2011-12-20 19:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 16:38 [PATCH] cgroup: remove redundate get/put of old css_set from migrate Mandeep Singh Baines
2011-12-17 16:41 ` Frederic Weisbecker
2011-12-19 2:01 ` Frederic Weisbecker
2011-12-19 17:16 ` Tejun Heo
2011-12-19 17:20 ` Tejun Heo
2011-12-19 18:44 ` [PATCH v2] " Mandeep Singh Baines
2011-12-20 18:45 ` Frederic Weisbecker
2011-12-20 19:01 ` [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration Frederic Weisbecker
2011-12-20 19:01 ` [PATCH 2/2] cgroup: Drop task_lock(parent) on cgroup_fork() Frederic Weisbecker
2011-12-20 19:14 ` [PATCH 1/2] cgroup: Remove unnecessary task_lock before fetching css_set on migration Tejun Heo
2011-12-20 19:27 ` Frederic Weisbecker [this message]
2011-12-20 21:29 ` Mandeep Singh Baines
2011-12-21 1:53 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220192703.GB17668@somewhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=msb@chromium.org \
--cc=oleg@redhat.com \
--cc=paul@paulmenage.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox