linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Martin <dave.martin@linaro.org>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Russell King <linux@arm.linux.org.uk>,
	Will Deacon <will.deacon@arm.com>, Felipe Balbi <balbi@ti.com>,
	Vladimir Zapolskiy <vz@mleia.com>,
	Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>,
	"open list:ARM PORT" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 02/10] arm: vexpress: fix kconfig warning
Date: Thu, 22 Dec 2011 11:39:16 +0000	[thread overview]
Message-ID: <20111222113916.GA2625@localhost> (raw)
In-Reply-To: <1324341747-5922-3-git-send-email-felipe.contreras@gmail.com>

On Tue, Dec 20, 2011 at 02:42:19AM +0200, Felipe Contreras wrote:
> warning: (ARCH_OMAP4 && ARCH_VEXPRESS_CA9X4) selects ARM_ERRATA_720789 which has unmet direct dependencies (CPU_V7 && SMP)
> warning: (ARCH_VEXPRESS_CA9X4) selects ARM_ERRATA_751472 which has unmet direct dependencies (CPU_V7 && SMP)
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  arch/arm/mach-vexpress/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index 9311484..3fbcb8c 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -5,8 +5,8 @@ config ARCH_VEXPRESS_CA9X4
>  	bool "Versatile Express Cortex-A9x4 tile"
>  	select CPU_V7
>  	select ARM_GIC
> -	select ARM_ERRATA_720789
> -	select ARM_ERRATA_751472
> +	select ARM_ERRATA_720789 if SMP
> +	select ARM_ERRATA_751472 if SMP
>  	select ARM_ERRATA_753970

NAK -- I hit this problem too, but in fact the errata configs should not
really be dependent on SMP; these are fixed in a couple of patches
currently queued in Russell's patch system:

7196/1 - errata: remove SMP dependency for erratum 720789
7197/1 - errata: remove SMP dependency for erratum 751472

...so we should avoid duplicating knowledge about exactly what these
errata workarounds do, where it can be avoided.

In the meantime, the warning is harmless.

Cheers
---Dave

  reply	other threads:[~2011-12-22 11:37 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20  0:42 [PATCH 00/10] kconfigs cleanups and fixes Felipe Contreras
2011-12-20  0:42 ` [PATCH 01/10] arm: omap4: fix kconfig warning Felipe Contreras
2011-12-22 18:22   ` Tony Lindgren
2011-12-22 20:09     ` Felipe Contreras
2011-12-22 20:45       ` Tony Lindgren
2011-12-20  0:42 ` [PATCH 02/10] arm: vexpress: " Felipe Contreras
2011-12-22 11:39   ` Dave Martin [this message]
2011-12-22 16:15     ` Felipe Contreras
2011-12-20  0:42 ` [PATCH 03/10] arm: omap2: fix omap3 touchbook " Felipe Contreras
2011-12-22 18:22   ` Tony Lindgren
2011-12-20  0:42 ` [PATCH 04/10] arm: omap2: fix regulator warnings Felipe Contreras
2011-12-22 18:23   ` Tony Lindgren
2011-12-20  0:42 ` [PATCH 05/10] usb: musb: trivial Kconfig cleanups Felipe Contreras
2011-12-20 12:03   ` Felipe Balbi
2011-12-20  0:42 ` [PATCH 06/10] usb: core: " Felipe Contreras
2011-12-20  0:42 ` [PATCH 07/10] usb: gadget: remove useless depends on Kconfig Felipe Contreras
2011-12-20 12:04   ` Felipe Balbi
2011-12-20  0:42 ` [PATCH 08/10] usb: gadget: remove useless dependency in config Felipe Contreras
2011-12-20 10:42   ` Felipe Balbi
2011-12-22 16:14     ` Felipe Contreras
2011-12-27 20:51       ` Felipe Balbi
2011-12-20  0:42 ` [PATCH 09/10] usb: otg: trivial cleanups Felipe Contreras
2011-12-20 12:04   ` Felipe Balbi
2011-12-20  0:42 ` [PATCH 10/10] musb: cleanup kconfig Felipe Contreras
2011-12-20 12:03   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111222113916.GA2625@localhost \
    --to=dave.martin@linaro.org \
    --cc=balbi@ti.com \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vz@mleia.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).